Sign upLogin

cyberark/secretless-broker

View on GitHub
Star

Showing 1,856 of 1,876 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package mysql

import (
    "net"
Severity: Major
Found in internal/plugin/connectors/tcp/mysql/plugin.go and 1 other location - About 2 hrs to fix
internal/plugin/connectors/tcp/pg/plugin.go on lines 1..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 229.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function TestSingleUseConnector_Connect has 110 lines of code (exceeds 70 allowed). Consider refactoring.
Open

func TestSingleUseConnector_Connect(t *testing.T) {
    t.Run("singleUseConnector.driver#Connect success", func(t *testing.T) {
        expectedBackendConn := mock.DefaultMSSQLConnectorCtor.BackendConn

        connector := newSingleUseConnectorWithOptions(
Severity: Major
Found in internal/plugin/connectors/tcp/mssql/connector_test.go - About 2 hrs to fix

    Function process_log has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def process_log(logfile_path, baseline_backend):
    percentages = {}
    baselines = []
    with open(logfile_path) as log_file:
        for line in log_file:
    Severity: Minor
    Found in bin/juxtaposer/aggregate.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *proxyServices) createSSHAgentService(
    config v2.Service,
) (internal.Service, error) {

    // TODO: Add validation somewhere about overlapping listenOns
    Severity: Major
    Found in internal/proxyservice/proxy_service.go and 1 other location - About 2 hrs to fix
    internal/proxyservice/proxy_service.go on lines 213..244

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 205.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *proxyServices) createSSHService(
    config v2.Service,
) (internal.Service, error) {

    // TODO: Add validation somewhere about overlapping listenOns
    Severity: Major
    Found in internal/proxyservice/proxy_service.go and 1 other location - About 2 hrs to fix
    internal/proxyservice/proxy_service.go on lines 246..277

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 205.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function TestEssentials has 99 lines of code (exceeds 70 allowed). Consider refactoring.
    Open

    func TestEssentials(t *testing.T) {
    testCases := []Definition{
        {
            Description: "with username, wrong password",
            ShouldPass:  true,
    Severity: Major
    Found in test/connector/tcp/pg/tests/essentials_test.go - About 2 hrs to fix

      Function TestEssentials has 98 lines of code (exceeds 70 allowed). Consider refactoring.
      Open

      func TestEssentials(t *testing.T) {
    testCases := []Definition{
        {
            Description: "with username, wrong password",
            ShouldPass:  true,
      Severity: Major
      Found in test/connector/tcp/mysql/tests/essentials_test.go - About 2 hrs to fix

        Method ServiceConnector.Connect has 92 lines of code (exceeds 70 allowed). Consider refactoring.
        Open

        func (h *ServiceConnector) Connect(
    credentialValuesByID connector.CredentialValuesByID,
) error {
    var err error
    var serverConfig ServerConfig
        Severity: Major
        Found in internal/plugin/connectors/ssh/service_connector.go - About 1 hr to fix

          Function TestExternalPlugins has 89 lines of code (exceeds 70 allowed). Consider refactoring.
          Open

          func TestExternalPlugins(t *testing.T) {
    t.Run("Assembles external plugins", func(t *testing.T) {
        externalPlugins, err := ExternalPluginsWithOptions(
            "",
            "",
          Severity: Major
          Found in pkg/secretless/plugin/sharedobj/external_plugins_test.go - About 1 hr to fix

            Function TestUnpackHandshakeV10 has 88 lines of code (exceeds 70 allowed). Consider refactoring.
            Open

            func TestUnpackHandshakeV10(t *testing.T) {

    type UnpackHandshakeV10Assert struct {
        Packet   []byte
        HasError bool
            Severity: Major
            Found in internal/plugin/connectors/tcp/mysql/protocol/protocol_test.go - About 1 hr to fix

              Function UnpackHandshakeV10 has 87 lines of code (exceeds 70 allowed). Consider refactoring.
              Open

              func UnpackHandshakeV10(packet []byte) (*HandshakeV10, error) {
    r := bytes.NewReader(packet)

    // Header
    header, err := GetPacketHeader(r)
              Severity: Major
              Found in internal/plugin/connectors/tcp/mysql/protocol/protocol.go - About 1 hr to fix

                Method AuthenticationHandshake.handleBackendAuthResponse has 87 lines of code (exceeds 70 allowed). Consider refactoring.
                Open

                func (h *AuthenticationHandshake) handleBackendAuthResponse() {
    if h.err != nil {
        return
    }
                Severity: Major
                Found in internal/plugin/connectors/tcp/mysql/authentication_handshake.go - About 1 hr to fix

                  Method LogTest.RunAllTests has 86 lines of code (exceeds 70 allowed). Consider refactoring.
                  Open

                  func (lt *LogTest) RunAllTests(t *testing.T) {

    // Format strings and sample arguments used in the test cases
    const testCaseFormatStr = "aaa %s bbb %d ccc %2.1f ddd \t eee"
    testCaseArgs := []interface{}{"stringval", 123, 1.234}
                  Severity: Major
                  Found in internal/log/log_test.go - About 1 hr to fix

                    Method AuthenticationHandshake.handleBackendAuthResponse has 17 return statements (exceeds 7 allowed).
                    Open

                    func (h *AuthenticationHandshake) handleBackendAuthResponse() {
    if h.err != nil {
        return
    }
                    Severity: Major
                    Found in internal/plugin/connectors/tcp/mysql/authentication_handshake.go - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          t.Run(label+": basic hydration", func(t *testing.T) {
        cfg, err := sampleConfig(sampleContents)
        assert.NoError(t, err)
        if err != nil {
            return
                      Severity: Major
                      Found in pkg/secretless/config/v2/config_test.go and 1 other location - About 1 hr to fix
                      pkg/secretless/config/v2/config_test.go on lines 118..128

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 147.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          t.Run(label+": http hydration", func(t *testing.T) {
        cfg, err := sampleConfig(sampleContents)
        assert.NoError(t, err)
        if err != nil {
            return
                      Severity: Major
                      Found in pkg/secretless/config/v2/config_test.go and 1 other location - About 1 hr to fix
                      pkg/secretless/config/v2/config_test.go on lines 95..105

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 147.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          for _, tc := range testCases {
        t.Run(tc.name, func(t *testing.T) {
            resp, err := UnpackAuthRequestPubKeyResponse(tc.input)

            if tc.expectedError != "" {
                      Severity: Major
                      Found in internal/plugin/connectors/tcp/mysql/protocol/protocol_test.go and 1 other location - About 1 hr to fix
                      internal/plugin/connectors/tcp/mysql/protocol/protocol_test.go on lines 616..629

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 146.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          for _, tc := range testCases {
        t.Run(tc.name, func(t *testing.T) {
            resp, err := UnpackAuthMoreDataResponse(tc.input)

            if tc.expectedError != "" {
                      Severity: Major
                      Found in internal/plugin/connectors/tcp/mysql/protocol/protocol_test.go and 1 other location - About 1 hr to fix
                      internal/plugin/connectors/tcp/mysql/protocol/protocol_test.go on lines 563..576

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 146.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method proxyService.Start has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
                      Open

                      func (proxy *proxyService) Start() error {
    logger := proxy.logger

    logger.Infof("Starting service")
                      Severity: Minor
                      Found in internal/plugin/connectors/ssh/proxy_service.go - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function extractShellCommand has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function extractShellCommand(shellBlock) {
  var blockLines = shellBlock.innerText.split("\n");
  var command = "";

  var includeNextLine = true;
                      Severity: Minor
                      Found in docs/javascript/clipboard-buttons.js - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language