Sign upLogin

cyberark/secretless-broker

View on GitHub
Star
test/util/testutil/config_generator.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function GenerateConfigurations has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
Open

func GenerateConfigurations() (config_v2.Config, LiveConfigurations) {
    // initialised with health-check listener and handler
    secretlessConfig := config_v2.Config{
        Services: []*config_v2.Service{
            {
Severity: Minor
Found in test/util/testutil/config_generator.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GenerateConfigurations has 127 lines of code (exceeds 70 allowed). Consider refactoring.
Open

func GenerateConfigurations() (config_v2.Config, LiveConfigurations) {
    // initialised with health-check listener and handler
    secretlessConfig := config_v2.Config{
        Services: []*config_v2.Service{
            {
Severity: Major
Found in test/util/testutil/config_generator.go - About 3 hrs to fix

    TODO found
    Open

    // TODO: consider parametrising ConnectPort generator
    Severity: Minor
    Found in test/util/testutil/config_generator.go by fixme

    TODO found
    Open

                                            // TODO: grab value from envvar for flexibility
    Severity: Minor
    Found in test/util/testutil/config_generator.go by fixme

    TODO found
    Open

                                            // TODO: perhaps resolve this duplication of listener type
    Severity: Minor
    Found in test/util/testutil/config_generator.go by fixme

    TODO found
    Open

        // TODO: Create a utility xprod function similar to the one here:
    Severity: Minor
    Found in test/util/testutil/config_generator.go by fixme

    TODO found
    Open

        // TODO: Remove "Value" suffixes -- no need for them, the lower case first letter
    Severity: Minor
    Found in test/util/testutil/config_generator.go by fixme

    There are no issues that match your filters.

    Category
    Status