dalisoft/nanoexpress

View on GitHub

Showing 50 of 50 total issues

Function nanoexpress has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
Open

const nanoexpress = (options = {}) => {
  const time = Date.now(); // For better managing start-time / lags
  let app;
  let ajv;

Severity: Minor
Found in src/nanoexpress.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (cache) {
    return cache.wrap(
      `${path}_${mtimeutc}_${start}_${end}_${compressed}`,
      (cb) => {
        stob(readStream)
Severity: Major
Found in src/helpers/sifrr-server/send-file.js and 1 other location - About 1 day to fix
src/helpers/send-file.js on lines 100..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 322.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  if (cache && !compressed) {
    return cache.wrap(
      `${path}_${mtimeutc}_${start}_${end}`,
      (cb) => {
        stream2Buffer(readStream)
Severity: Major
Found in src/helpers/send-file.js and 1 other location - About 1 day to fix
src/helpers/sifrr-server/send-file.js on lines 114..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 322.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function nanoexpress has 280 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const nanoexpress = (options = {}) => {
  const time = Date.now(); // For better managing start-time / lags
  let app;
  let ajv;

Severity: Major
Found in src/nanoexpress.js - About 1 day to fix

    Function swaggerDocsGenerator has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function swaggerDocsGenerator(
      swaggerDef,
      path,
      method,
      { schema, contentType = '*', ...routeConfigs } = {}
    Severity: Minor
    Found in src/helpers/prepare-swagger-docs.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File nanoexpress.js has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import uWS from 'uWebSockets.js';
    
    import fs from 'fs';
    import { resolve } from 'path';
    import util from 'util';
    Severity: Minor
    Found in src/nanoexpress.js - About 3 hrs to fix

      Function exports has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = (config = {}) => {
        if (config.title === undefined) {
          config.title = 'nanoexpress - Swagger UI';
        }
        if (config.path === undefined) {
      Severity: Major
      Found in src/packed/middlewares/swagger-ui.js - About 2 hrs to fix

        Function default has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

        export default async function (
          path,
          {
            lastModified = true,
            compress = false,
        Severity: Minor
        Found in src/helpers/send-file.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function listen has 69 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              new Promise((resolve, reject) => {
                if (typeof port === 'string' && port.indexOf('.') !== -1) {
                  const _port = host;
        
                  host = port;
        Severity: Major
        Found in src/nanoexpress.js - About 2 hrs to fix

          Function sendFileToRes has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

          async function sendFileToRes(
            res,
            reqHeaders,
            path,
            {
          Severity: Minor
          Found in src/helpers/sifrr-server/send-file.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function newFnString has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const newFnString = lineGoHandle(fnString, (line, index) => {
              line = line.trim();
          
              if (!line) {
                return line;
          Severity: Major
          Found in src/helpers/is-simple-handler.js - About 2 hrs to fix

            Function send has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            export default function send(result) {
              /* If we were aborted, you cannot respond */
              if (this.aborted) {
                logger.error('[Server]: Error, Response was aborted before responsing');
                return undefined;
            Severity: Minor
            Found in src/proto/http/response-chunks/send.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handler has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                : async (req, res, config) => {
                    let middlewareChainingTransferPreviousResult;
                    for (const fn of prepared) {
                      if (fn.simple || !fn.async) {
                        fn(req, res, config, middlewareChainingTransferPreviousResult);
            Severity: Major
            Found in src/middlewares/http.js - About 2 hrs to fix

              Function normalizeLocation has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

              export const normalizeLocation = (path, config, host) => {
                if (path.indexOf('http') === -1) {
                  if (path.indexOf('/') === -1) {
                    path = '/' + path;
                  }
              Severity: Minor
              Found in src/proto/http/polyfill-chunks/redirect.js - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                readStream
                  .on('error', () => {
                    res.writeStatus('500 Internal server error');
                    res.end();
                    readStream.destroy();
              Severity: Major
              Found in src/helpers/send-file.js and 1 other location - About 1 hr to fix
              src/helpers/sifrr-server/send-file.js on lines 178..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                readStream
                  .on('error', () => {
                    res.writeStatus('500 Internal server error');
                    res.end();
                    readStream.destroy();
              Severity: Major
              Found in src/helpers/sifrr-server/send-file.js and 1 other location - About 1 hr to fix
              src/helpers/send-file.js on lines 164..172

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function prepared has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  .map((fn, index) => {
                    let result;
                    if (!fn || typeof fn === 'object') {
                      return null;
                    }
              Severity: Minor
              Found in src/helpers/prepare-route-functions.js - About 1 hr to fix

                Function method has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    _app[method] = (path, ...fns) => {
                      let isPrefix;
                      let isDirect;
                      if (fns.length > 0) {
                        const isRaw = fns.find((fn) => fn.isRaw === true);
                Severity: Minor
                Found in src/nanoexpress.js - About 1 hr to fix

                  Function modifyEnd has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Confirmed

                  export default function modifyEnd() {
                    if (!this._modifiedEnd) {
                      const _oldEnd = this.end;
                  
                      this.end = function (chunk, encoding) {
                  Severity: Minor
                  Found in src/proto/http/response-chunks/modify-end.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function body has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Confirmed

                    let body = await new Promise((resolve) => {
                      /* Register error cb */
                      if (!res.abortHandler && res.onAborted) {
                        res.onAborted(() => {
                          if (res.stream) {
                  Severity: Minor
                  Found in src/normalizers/body.js - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language