Sign upLogin

dalisoft/nanoexpress

View on GitHub
Star

Showing 50 of 50 total issues

Function send has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function send(result) {
  /* If we were aborted, you cannot respond */
  if (this.aborted) {
    logger.error('[Server]: Error, Response was aborted before responsing');
    return undefined;
Severity: Minor
Found in src/proto/http/response-chunks/send.js - About 1 hr to fix

    Function onListen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            const onListen = (token) => {
          if (typeof host === 'string') {
            config.host = host;
          } else {
            config.host = 'localhost';
    Severity: Minor
    Found in src/nanoexpress.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            res.onAborted(() => {
        if (res.stream) {
          res.stream.destroy();
        }
        res.aborted = true;
      Severity: Minor
      Found in src/handler/http.js and 1 other location - About 50 mins to fix
      src/helpers/sifrr-server/send-file.js on lines 20..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          res.onAborted(() => {
      if (res.stream) {
        res.stream.destroy();
      }
      res.aborted = true;
      Severity: Minor
      Found in src/helpers/sifrr-server/send-file.js and 1 other location - About 50 mins to fix
      src/handler/http.js on lines 118..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function applyHeadersAndStatus has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function applyHeadersAndStatus() {
  const { _headers, statusCode } = this;

  if (typeof statusCode === 'string') {
    this.writeStatus(statusCode);
      Severity: Minor
      Found in src/proto/http/header-chunks/apply-headers-and-status.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                if (!value.content) {
            schema[typeName][httpCode] = { content: { [contentType]: value } };
            value = schema[typeName][httpCode].content[contentType];
          }
      Severity: Major
      Found in src/helpers/prepare-swagger-docs.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        if (config._errorHandler) {
                  return config._errorHandler(middleware.error, req, res);
                }
        Severity: Major
        Found in src/middlewares/http.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    if (!value.schema) {
            schema[typeName][httpCode].content[contentType] = { schema: value };
          }
          Severity: Major
          Found in src/helpers/prepare-swagger-docs.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (!validationStringify) {
              validationStringify = fastJson(validationSchema);
            }
            Severity: Major
            Found in src/helpers/prepare-validation.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              if (config._errorHandler) {
                  return config._errorHandler(error, req, res);
                }
              Severity: Major
              Found in src/middlewares/http.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            for (const code in _schema) {
              newSchema[code] = fastJson(_schema[code]);
            }
                Severity: Major
                Found in src/helpers/prepare-validation.js - About 45 mins to fix

                  Function writeHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export default function writeHeaders(headers) {
  for (const header in headers) {
    const value = headers[header];
    if (value) {
      if (value.splice) {
                  Severity: Minor
                  Found in src/proto/http/header-chunks/write-headers.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function setHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export default function setHeaders(headers) {
  for (const header in headers) {
    if (this._headers) {
      const currentHeader = this._headers[header];
      if (currentHeader !== undefined || currentHeader !== null) {
                  Severity: Minor
                  Found in src/proto/http/header-chunks/set-headers.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this function.
                  Open

                        return fn(request, response, config);
                  Severity: Major
                  Found in src/handler/http.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                  return;
                    Severity: Major
                    Found in src/middlewares/http.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return res.send(errors);
                      Severity: Major
                      Found in src/handler/http.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return { simple: false, reason: 'error' };
                        Severity: Major
                        Found in src/helpers/is-simple-handler.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return res.end(
                  `{"middleware_type":"${fn.type}",error":"${middleware.error.message}"}`
                );
                          Severity: Major
                          Found in src/middlewares/http.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                      return res;
                            Severity: Major
                            Found in src/middlewares/http.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return res.send(validationHandler);
                              Severity: Major
                              Found in src/handler/http.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language