damianwajser/spring-rest-commons-options

View on GitHub
src/main/java/com/github/damianwajser/model/validators/ValidatorFactory.java

Summary

Maintainability
A
25 mins
Test Coverage

Method getValidator has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private static Optional<Validator> getValidator(Annotation annotation) {
        Validator validator = null;

        if (isValidable(annotation)) {
            if (annotation instanceof Range || annotation instanceof Length) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is longer than 100 characters (found 107).
Open

    private static Optional<List<Validator>> completeValidations(Optional<List<Validator>> validations,

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 123).
Open

    public static Optional<List<Validator>> getValidations(PropertyDescriptor fieldDescriptor, Optional<Field> field) {

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Local variable name 'p' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

        Package p = annotation.annotationType().getPackage();

Checks that local, non-final variable names conform to a specified pattern.A catch parameter is considered to be a local variable.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'org.hibernate.validator.constraints.Length'
Open

import org.hibernate.validator.constraints.Length;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'com.github.damianwajser.model.validators.impl.RangeValidator' import. Should be before 'org.hibernate.validator.constraints.Range'.
Open

import com.github.damianwajser.model.validators.impl.RangeValidator;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 103).
Open

            List<Annotation> annotationField = Arrays.asList(field.get().getAnnotations());

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Line is longer than 100 characters (found 101).
Open

    private static List<String> validatorsPackage = Arrays.asList("javax.validation.constraints",

Checks for long lines.

Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'com.github.damianwajser.model.validators.impl.PatternValidator' import. Should be before 'org.hibernate.validator.constraints.Range'.
Open

import com.github.damianwajser.model.validators.impl.PatternValidator;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'com.github.damianwajser.model.validators.impl.DefaultValidator'
Open

import com.github.damianwajser.model.validators.impl.DefaultValidator;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Extra separation in import group before 'javax.validation.constraints.Pattern'
Open

import javax.validation.constraints.Pattern;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Wrong lexicographical order for 'com.github.damianwajser.model.validators.impl.DefaultValidator' import. Should be before 'org.hibernate.validator.constraints.Range'.
Open

import com.github.damianwajser.model.validators.impl.DefaultValidator;

Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status