Sign upLogin

danini-the-panini/mittsu-opengl

View on GitHub
Star
lib/mittsu/opengl/state.rb

Summary

Maintainability
B
5 hrs
Test Coverage
C
76%

Method has too many lines. [49/30]
Open

    def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
      if blending != @current_blending
        case blending
        when NoBlending
          GL.Disable(GL::BLEND)
Severity: Minor
Found in lib/mittsu/opengl/state.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for set_blending is too high. [14/6]
Open

    def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
      if blending != @current_blending
        case blending
        when NoBlending
          GL.Disable(GL::BLEND)
Severity: Minor
Found in lib/mittsu/opengl/state.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method set_blending has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
      if blending != @current_blending
        case blending
        when NoBlending
          GL.Disable(GL::BLEND)
Severity: Minor
Found in lib/mittsu/opengl/state.rb - About 1 hr to fix

    Method set_blending has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
      if blending != @current_blending
        case blending
        when NoBlending
          GL.Disable(GL::BLEND)
    Severity: Minor
    Found in lib/mittsu/opengl/state.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_blending has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
    Severity: Major
    Found in lib/mittsu/opengl/state.rb - About 50 mins to fix

      Method set_polygon_offset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def set_polygon_offset(polygon_offset, factor, units)
      if @current_polygon_offset != polygon_offset
        if polygon_offset
          GL.Enable(GL::POLYGON_OFFSET_FILL)
        else
      Severity: Minor
      Found in lib/mittsu/opengl/state.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid parameter lists longer than 5 parameters. [7/5]
      Open

          def set_blending(blending, blend_equation = nil, blend_src = nil, blend_dst = nil, blend_equation_alpha = nil, blend_src_alpha = nil, blend_dst_alpha = nil)
      Severity: Minor
      Found in lib/mittsu/opengl/state.rb by rubocop

      This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

      TODO found
      Open

                # TODO: Find blendFuncSeparate() combination ???
      Severity: Minor
      Found in lib/mittsu/opengl/state.rb by fixme

      TODO found
      Open

                # TODO: Find blendFuncSeparate() combination ???
      Severity: Minor
      Found in lib/mittsu/opengl/state.rb by fixme

      There are no issues that match your filters.

      Category
      Status