Sign upLogin

danini-the-panini/mittsu-opengl

View on GitHub
Star
lib/mittsu/opengl_implementation/textures/cube_texture.rb

Summary

Maintainability
C
1 day
Test Coverage
C
78%

Method set has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def set(slot, renderer)
      @renderer = renderer

      if image.length == 6
        if needs_update?
Severity: Minor
Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [57/30]
Open

    def set(slot, renderer)
      @renderer = renderer

      if image.length == 6
        if needs_update?
Severity: Minor
Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for set is too high. [17/6]
Open

    def set(slot, renderer)
      @renderer = renderer

      if image.length == 6
        if needs_update?
Severity: Minor
Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method set has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def set(slot, renderer)
      @renderer = renderer

      if image.length == 6
        if needs_update?
Severity: Major
Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                      if @renderer.compressed_texture_formats.include?(gl_format)
                    GL.CompressedTexImage2D(GL::TEXTURE_CUBE_MAP_POSITIVE_X + i, j, gl_format, mipmap.width, mipmap.height, 0, mipmap.data)
                  else
                    puts "WARNING: Mittsu::OpenGLCubeTexture: Attempt to load unsupported compressed texture format in #set"
                  end
    Severity: Major
    Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb - About 45 mins to fix

      Avoid more than 4 levels of block nesting.
      Open

                        if @renderer.compressed_texture_formats.include?(gl_format)
                    GL.CompressedTexImage2D(GL::TEXTURE_CUBE_MAP_POSITIVE_X + i, j, gl_format, mipmap.width, mipmap.height, 0, mipmap.data)
                  else
                    puts "WARNING: Mittsu::OpenGLCubeTexture: Attempt to load unsupported compressed texture format in #set"
                  end
      Severity: Minor
      Found in lib/mittsu/opengl_implementation/textures/cube_texture.rb by rubocop

      This cop checks for excessive nesting of conditional and looping constructs.

      You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

      The maximum level of nesting allowed is configurable.

      There are no issues that match your filters.

      Category
      Status