Sign upLogin

danini-the-panini/mittsu

View on GitHub
Star

Showing 659 of 659 total issues

Redundant use of Object#to_s in interpolation.
Open

    file_name = "#{key.to_s}.glsl"
Severity: Minor
Found in lib/mittsu/renderers/shaders/shader_chunk.rb by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Unused block argument - m. You can omit the argument if you don't care about it.
Open

        @num_morph_targets.times do |m|
Severity: Minor
Found in lib/mittsu/renderers/opengl/opengl_geometry_group.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

end at 329, 12 is not aligned with case at 323, 19.
Open

            end
Severity: Minor
Found in lib/mittsu/renderers/opengl/core/geometry.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z, _w = @x, @y, @z, @w
Severity: Minor
Found in lib/mittsu/math/quaternion.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Unused method argument - p3. If it's necessary, use _ or _p3 as an argument name to indicate that it won't be used.
Open

    def interpolate(p0, p1, p2, p3, t, t2, t3)
Severity: Minor
Found in lib/mittsu/math/spline.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Unused block argument - window_handle. If it's necessary, use _ or _window_handle as an argument name to indicate that it won't be used.
Open

        @key_callback = ::GLFW::create_callback(:GLFWkeyfun) do |window_handle, key, scancode, action, mods|
Severity: Minor
Found in lib/mittsu/renderers/glfw_window.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Comparison of something with itself detected.
Open

      tmax = tymax if tymax < tmax || tmax != tmax
Severity: Minor
Found in lib/mittsu/math/ray.rb by rubocop

This cop checks for comparison of something with itself.

Example:

# bad

x.top >= x.top

Comparison of something with itself detected.
Open

      tmin = tzmin if tzmin > tmin || tmin != tmin
Severity: Minor
Found in lib/mittsu/math/ray.rb by rubocop

This cop checks for comparison of something with itself.

Example:

# bad

x.top >= x.top

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Unused method argument - fog. If it's necessary, use _ or _fog as an argument name to indicate that it won't be used.
Open

    def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
Severity: Minor
Found in lib/mittsu/renderers/opengl/objects/mesh.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Comparison of something with itself detected.
Open

      tmin = tymin if tymin > tmin || tmin != tmin
Severity: Minor
Found in lib/mittsu/math/ray.rb by rubocop

This cop checks for comparison of something with itself.

Example:

# bad

x.top >= x.top

Unused method argument - update_buffers. If it's necessary, use _ or _update_buffers as an argument name to indicate that it won't be used.
Open

    def render_buffer(camera, lights, fog, material, geometry_group, update_buffers)
Severity: Minor
Found in lib/mittsu/renderers/opengl/objects/point_cloud.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - m. You can omit the argument if you don't care about it.
Open

        num_morph_targets.times do |m|
Severity: Minor
Found in lib/mittsu/renderers/opengl/opengl_geometry_group.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Unused block argument - chf. You can omit the argument if you don't care about it.
Open

        @faces3.each do |chf|
Severity: Minor
Found in lib/mittsu/renderers/opengl/opengl_geometry_group.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z = *@elements
Severity: Minor
Found in lib/mittsu/math/vector3.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end

Do not use prefix _ for a variable that is used.
Open

      _x, _y, _z, _w = *@elements
Severity: Minor
Found in lib/mittsu/math/vector4.rb by rubocop

This cop checks for underscore-prefixed variables that are actually used.

Example:

# bad

[1, 2, 3].each do |_num|
  do_something(_num)
end

Example:

# good

[1, 2, 3].each do |num|
  do_something(num)
end

Example:

# good

[1, 2, 3].each do |_num|
  do_something # not using `_num`
end
Severity
Category
Status
Source
Language