Sign upLogin

danmayer/coverband

View on GitHub
Star

Showing 37 of 37 total issues

Class Configuration has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Configuration
    attr_accessor :root_paths, :root,
      :verbose,
      :reporter, :redis_namespace, :redis_ttl,
      :background_reporting_enabled,
Severity: Minor
Found in lib/coverband/configuration.rb - About 4 hrs to fix

    Method start has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.start
      return if running?

      logger = Coverband.configuration.logger
      @semaphore.synchronize do
    Severity: Minor
    Found in lib/coverband/integrations/background.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method report_coverage has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

          def report_coverage
        @semaphore.synchronize do
          raise "no Coverband store set" unless @store

          files_with_line_usage = filtered_files(Delta.results)
    Severity: Minor
    Found in lib/coverband/collectors/coverage.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method array_add has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

          def array_add(latest, original)
        if Coverband.configuration.use_oneshot_lines_coverage
          latest.map!.with_index { |v, i| ((v + original[i] >= 1) ? 1 : 0) if v && original[i] }
        elsif Coverband.configuration.simulate_oneshot_lines_coverage
          latest.map.with_index { |v, i| ((v + original[i] >= 1) ? 1 : 0) if v && original[i] }
    Severity: Minor
    Found in lib/coverband/adapters/base.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class HTMLFormatter has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class HTMLFormatter
      attr_reader :notice, :base_path, :tracker

      def initialize(report, options = {})
        @notice = options.fetch(:notice, nil)
    Severity: Minor
    Found in lib/coverband/utils/html_formatter.rb - About 3 hrs to fix

      Class SourceFile has 25 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class SourceFile
      # TODO: Refactor Line into its own file
      # Representation of a single line in a source file including
      # this specific line's source code, line_number and code coverage,
      # with the coverage being either nil (coverage not applicable, e.g. comment
      Severity: Minor
      Found in lib/coverband/utils/source_file.rb - About 2 hrs to fix

        Method initialize has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

              def initialize
        @semaphore = Mutex.new
        raise NotImplementedError, "Coverage needs Ruby > 2.3.0" if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.3.0")

        require "coverage"
        Severity: Minor
        Found in lib/coverband/collectors/coverage.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class AbstractTracker has 23 methods (exceeds 20 allowed). Consider refactoring.
        Open

            class AbstractTracker
      REPORT_ROUTE = "/"
      TITLE = "abstract"

      attr_accessor :target
        Severity: Minor
        Found in lib/coverband/collectors/abstract_tracker.rb - About 2 hrs to fix

          Method call has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

                def call(env)
        @request = Rack::Request.new(env)

        return [401, {"www-authenticate" => 'Basic realm=""'}, [""]] unless check_auth
          Severity: Minor
          Found in lib/coverband/reporters/web.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method generate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

                def generate
        current_coverage.each_with_object({}) do |(file, line_counts), new_results|
          ###
          # Eager filter:
          # Normally I would break this out into additional methods
          Severity: Minor
          Found in lib/coverband/collectors/delta.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method call has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def call(env)
        @request = Rack::Request.new(env)

        return [401, {"www-authenticate" => 'Basic realm=""'}, [""]] unless check_auth
          Severity: Minor
          Found in lib/coverband/reporters/web.rb - About 1 hr to fix

            Method reset has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def reset
      @root = Dir.pwd
      @root_paths = []
      @ignore = IGNORE_DEFAULTS.dup
      @search_paths = TRACKED_DEFAULT_PATHS.dup
            Severity: Minor
            Found in lib/coverband/configuration.rb - About 1 hr to fix

              Method get_current_scov_data_imp has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
              Open

                      def get_current_scov_data_imp(store, roots)
          scov_style_report = {}
          store.get_coverage_report.each_pair do |name, data|
            data.each_pair do |key, line_data|
              next if Coverband.configuration.ignore.any? { |i| key.match(i) }
              Severity: Minor
              Found in lib/coverband/reporters/base.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method track_key has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def track_key(payload)
        if (file = payload[:identifier])
          if newly_seen_key?(file)
            @logged_keys << file
            @keys_to_record << file if track_file?(file)
              Severity: Minor
              Found in lib/coverband/collectors/view_tracker.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method build_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def build_response(req)
        uri = URI.parse(path(req.path_parameters, req))

        unless uri.host
          if relative_path?(uri.path)
              Severity: Minor
              Found in lib/coverband/utils/rails6_ext.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method railtie! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  def railtie!
      if Coverband.configuration.track_routes
        Coverband.configuration.route_tracker = Coverband::Collectors::RouteTracker.new
        trackers << Coverband.configuration.route_tracker
      end
              Severity: Minor
              Found in lib/coverband/configuration.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method coverage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                    def coverage(local_type = nil, opts = {})
        return if Coverband.configuration.service_disabled_dev_test_env?

        local_type ||= opts.key?(:override_type) ? opts[:override_type] : type
        env_filter = opts.key?(:env_filter) ? opts[:env_filter] : "production"
              Severity: Minor
              Found in lib/coverband/adapters/web_service_store.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def initialize
        @semaphore = Mutex.new
        raise NotImplementedError, "Coverage needs Ruby > 2.3.0" if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.3.0")

        require "coverage"
              Severity: Minor
              Found in lib/coverband/collectors/coverage.rb - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def coverage(local_type = nil, opts = {})
        local_type ||= opts.key?(:override_type) ? opts[:override_type] : type
        data = redis.get type_base_key(local_type)
        data = data ? JSON.parse(data) : {}
        data.delete_if { |file_path, file_data| file_hash(file_path) != file_data["file_hash"] } unless opts[:skip_hash_check]
                Severity: Minor
                Found in lib/coverband/adapters/redis_store.rb and 1 other location - About 55 mins to fix
                lib/coverband/adapters/memcached_store.rb on lines 48..53

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def coverage(local_type = nil, opts = {})
        local_type ||= opts.key?(:override_type) ? opts[:override_type] : type
        data = memcached.read(type_base_key(local_type))
        data = data ? JSON.parse(data) : {}
        data.delete_if { |file_path, file_data| file_hash(file_path) != file_data["file_hash"] } unless opts[:skip_hash_check]
                Severity: Minor
                Found in lib/coverband/adapters/memcached_store.rb and 1 other location - About 55 mins to fix
                lib/coverband/adapters/redis_store.rb on lines 75..80

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language