datacite/levriero

View on GitHub
app/models/concerns/importable.rb

Summary

Maintainability
C
1 day
Test Coverage
C
77%

Perceived complexity for parse_record is too high. [28/8]
Open

    def parse_record(sqs_msg: nil, data: nil)
      id = "https://doi.org/#{data['id']}"
      response = get_datacite_json(id)
      related_identifiers = Array.wrap(response.fetch("relatedIdentifiers",
                                                      nil)).select do |r|
Severity: Minor
Found in app/models/concerns/importable.rb by rubocop

Tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method parse_record has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_record(sqs_msg: nil, data: nil)
      id = "https://doi.org/#{data['id']}"
      response = get_datacite_json(id)
      related_identifiers = Array.wrap(response.fetch("relatedIdentifiers",
                                                      nil)).select do |r|
Severity: Major
Found in app/models/concerns/importable.rb - About 3 hrs to fix

    Method parse_record has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_record(sqs_msg: nil, data: nil)
          id = "https://doi.org/#{data['id']}"
          response = get_datacite_json(id)
          related_identifiers = Array.wrap(response.fetch("relatedIdentifiers",
                                                          nil)).select do |r|
    Severity: Minor
    Found in app/models/concerns/importable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalize_pmid has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def normalize_pmid(id)
          return nil if id.blank?
    
          id = id.downcase
    
    
    Severity: Minor
    Found in app/models/concerns/importable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalize_igsn has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def normalize_igsn(id)
          return nil if id.blank?
    
          id = id.downcase
    
    
    Severity: Minor
    Found in app/models/concerns/importable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method normalize_handle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def normalize_handle(id)
          return nil if id.blank?
    
          id = id.downcase
    
    
    Severity: Minor
    Found in app/models/concerns/importable.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import_from_api has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def import_from_api
          route = "#{name.downcase}s"
          page_number = 1
          total_pages = 1
          total = 0
    Severity: Minor
    Found in app/models/concerns/importable.rb - About 1 hr to fix

      Method normalize_arxiv has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def normalize_arxiv(id)
            return nil if id.blank?
      
            id = id.downcase
      
      
      Severity: Minor
      Found in app/models/concerns/importable.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method normalize_url has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def normalize_url(id)
            return nil if id.blank?
      
            # check for valid protocol. We support AWS S3 and Google Cloud Storage
            uri = Addressable::URI.parse(id)
      Severity: Minor
      Found in app/models/concerns/importable.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_from_api has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def import_from_api
            route = "#{name.downcase}s"
            page_number = 1
            total_pages = 1
            total = 0
      Severity: Minor
      Found in app/models/concerns/importable.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Do not read from ENV directly post initialization.
      Open

              url = ENV["API_URL"] + "/#{route}?" + URI.encode_www_form(params)
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
      Open

              ["DOI", "URL"].include?(r["relatedIdentifierType"])
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Line is too long. [183/120]
      Open

            Rails.logger.info "No events found for DOI #{data['id']}" if related_identifiers.blank? && name_identifiers.blank? && funding_references.blank? && affiliation_identifiers.blank?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [160/120]
      Open

            Rails.logger.info "[Event Data] #{affiliation_identifiers.length} affiliation_identifiers found for DOI #{data['id']}" if affiliation_identifiers.present?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [152/120]
      Open

            orcid = Array(/\A(?:(http|https):\/\/(www\.)?orcid\.org\/)?(\d{4}[[:space:]-]\d{4}[[:space:]-]\d{4}[[:space:]-]\d{3}[0-9X]+)\z/.match(orcid)).last
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [149/120]
      Open

            Rails.logger.info "[Event Data] #{orcid_affiliation.length} orcid_affiliations found for DOI #{data['id']}" if affiliation_identifiers.present?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [148/120]
      Open

            Rails.logger.info "[Event Data] #{related_identifiers.length} related_identifiers found for DOI #{data['id']}" if related_identifiers.present?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [145/120]
      Open

            Rails.logger.info "[Event Data] #{funding_references.length} funding_references found for DOI #{data['id']}" if funding_references.present?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Line is too long. [139/120]
      Open

            Rails.logger.info "[Event Data] #{name_identifiers.length} name_identifiers found for DOI #{data['id']}" if name_identifiers.present?
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/IndentationStyle cop. It also ignores a shebang line by default.

      This cop has some autocorrection capabilities. It can programmatically shorten certain long lines by inserting line breaks into expressions that can be safely split across lines. These include arrays, hashes, and method calls with argument lists.

      If autocorrection is enabled, the following Layout cops are recommended to further format the broken lines. (Many of these are enabled by default.)

      • ArgumentAlignment
      • ArrayAlignment
      • BlockAlignment
      • BlockDelimiters
      • BlockEndNewline
      • ClosingParenthesisIndentation
      • FirstArgumentIndentation
      • FirstArrayElementIndentation
      • FirstHashElementIndentation
      • FirstParameterIndentation
      • HashAlignment
      • IndentationWidth
      • MultilineArrayLineBreaks
      • MultilineBlockLayout
      • MultilineHashBraceLayout
      • MultilineHashKeyLineBreaks
      • MultilineMethodArgumentLineBreaks
      • MultilineMethodParameterLineBreaks
      • ParameterAlignment

      Together, these cops will pretty print hashes, arrays, method calls, etc. For example, let's say the max columns is 25:

      Example:

      # bad
      {foo: "0000000000", bar: "0000000000", baz: "0000000000"}
      
      # good
      {foo: "0000000000",
      bar: "0000000000", baz: "0000000000"}
      
      # good (with recommended cops enabled)
      {
        foo: "0000000000",
        bar: "0000000000",
        baz: "0000000000",
      }

      Shadowing outer local variable - n.
      Open

                                 nil)).any? do |n|
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks for the use of local variable names from an outer scope in block arguments or block-local variables. This mirrors the warning given by ruby -cw prior to Ruby 2.6: "shadowing outer local variable - foo".

      NOTE: Shadowing of variables in block passed to Ractor.new is allowed because Ractor should not access outer variables. eg. following style is encouraged:

      ```ruby
      worker_id, pipe = env
      Ractor.new(worker_id, pipe) do |worker_id, pipe|
      end
      ```

      Example:

      # bad
      
      def some_method
        foo = 1
      
        2.times do |foo| # shadowing outer `foo`
          do_something(foo)
        end
      end

      Example:

      # good
      
      def some_method
        foo = 1
      
        2.times do |bar|
          do_something(bar)
        end
      end

      Shadowing outer local variable - n.
      Open

                                 nil)).any? do |n|
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks for the use of local variable names from an outer scope in block arguments or block-local variables. This mirrors the warning given by ruby -cw prior to Ruby 2.6: "shadowing outer local variable - foo".

      NOTE: Shadowing of variables in block passed to Ractor.new is allowed because Ractor should not access outer variables. eg. following style is encouraged:

      ```ruby
      worker_id, pipe = env
      Ractor.new(worker_id, pipe) do |worker_id, pipe|
      end
      ```

      Example:

      # bad
      
      def some_method
        foo = 1
      
        2.times do |foo| # shadowing outer `foo`
          do_something(foo)
        end
      end

      Example:

      # good
      
      def some_method
        foo = 1
      
        2.times do |bar|
          do_something(bar)
        end
      end

      Shadowing outer local variable - n.
      Open

                                )).any? do |n|
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks for the use of local variable names from an outer scope in block arguments or block-local variables. This mirrors the warning given by ruby -cw prior to Ruby 2.6: "shadowing outer local variable - foo".

      NOTE: Shadowing of variables in block passed to Ractor.new is allowed because Ractor should not access outer variables. eg. following style is encouraged:

      ```ruby
      worker_id, pipe = env
      Ractor.new(worker_id, pipe) do |worker_id, pipe|
      end
      ```

      Example:

      # bad
      
      def some_method
        foo = 1
      
        2.times do |foo| # shadowing outer `foo`
          do_something(foo)
        end
      end

      Example:

      # good
      
      def some_method
        foo = 1
      
        2.times do |bar|
          do_something(bar)
        end
      end

      Shadowing outer local variable - n.
      Open

              Array.wrap(n.fetch("affiliation", nil)).any? do |n|
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks for the use of local variable names from an outer scope in block arguments or block-local variables. This mirrors the warning given by ruby -cw prior to Ruby 2.6: "shadowing outer local variable - foo".

      NOTE: Shadowing of variables in block passed to Ractor.new is allowed because Ractor should not access outer variables. eg. following style is encouraged:

      ```ruby
      worker_id, pipe = env
      Ractor.new(worker_id, pipe) do |worker_id, pipe|
      end
      ```

      Example:

      # bad
      
      def some_method
        foo = 1
      
        2.times do |foo| # shadowing outer `foo`
          do_something(foo)
        end
      end

      Example:

      # good
      
      def some_method
        foo = 1
      
        2.times do |bar|
          do_something(bar)
        end
      end

      Unused method argument - sqs_msg.
      Open

          def parse_record(sqs_msg: nil, data: nil)
      Severity: Minor
      Found in app/models/concerns/importable.rb by rubocop

      Checks for unused method arguments.

      Example:

      # bad
      def some_method(used, unused, _unused_but_allowed)
        puts used
      end
      
      # good
      def some_method(used, _unused, _unused_but_allowed)
        puts used
      end

      Example: AllowUnusedKeywordArguments: false (default)

      # bad
      def do_something(used, unused: 42)
        used
      end

      Example: AllowUnusedKeywordArguments: true

      # good
      def do_something(used, unused: 42)
        used
      end

      Example: IgnoreEmptyMethods: true (default)

      # good
      def do_something(unused)
      end

      Example: IgnoreEmptyMethods: false

      # bad
      def do_something(unused)
      end

      Example: IgnoreNotImplementedMethods: true (default)

      # good
      def do_something(unused)
        raise NotImplementedError
      end
      
      def do_something_else(unused)
        fail "TODO"
      end

      Example: IgnoreNotImplementedMethods: false

      # bad
      def do_something(unused)
        raise NotImplementedError
      end
      
      def do_something_else(unused)
        fail "TODO"
      end

      There are no issues that match your filters.

      Category
      Status