Sign upLogin

datacite/orcid_client

View on GitHub
Star
lib/orcid_client/work.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
92%

Class Work has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Work
    include OrcidClient::Base
    include OrcidClient::Author
    include OrcidClient::Date
    include OrcidClient::WorkType
Severity: Minor
Found in lib/orcid_client/work.rb - About 2 hrs to fix

    Method insert_pub_date has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def insert_pub_date(xml)
      if publication_date['year']
        xml.send(:'common:publication-date') do
          xml.year(publication_date.fetch('year'))
          xml.month(publication_date.fetch('month', nil)) if publication_date['month']
    Severity: Minor
    Found in lib/orcid_client/work.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status