Sign upLogin

datacite/volpino

View on GitHub
Star
app/models/claim.rb

Summary

Maintainability
D
2 days
Test Coverage
D
62%

File claim.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "nokogiri"
require "orcid_client"

class Claim < ApplicationRecord
  # include view helpers
Severity: Minor
Found in app/models/claim.rb - About 2 hrs to fix

    Method collect_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      def collect_data(options = {})
    # user has not signed up yet or orcid_token is missing
    if user.blank? || orcid_token.blank?
      if ENV["NOTIFICATION_ACCESS_TOKEN"].present?
        response = notification.create_notification(options)
    Severity: Minor
    Found in app/models/claim.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import_by_id has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
    Severity: Minor
    Found in app/models/claim.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import_by_id has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
    Severity: Minor
    Found in app/models/claim.rb - About 1 hr to fix

      Method process_data has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def process_data(options = {})
    start

    result = collect_data
      Severity: Minor
      Found in app/models/claim.rb - About 1 hr to fix

        Method process_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def process_data(options = {})
    start

    result = collect_data
        Severity: Minor
        Found in app/models/claim.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return OpenStruct.new(body: { "errors" => [{ "title" => "Missing data" }] }) if work.data.nil?
        Severity: Major
        Found in app/models/claim.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return OpenStruct.new(body: { "errors" => [{ "status" => 401, "title" => "token has expired." }] }) if (Date.new(1970, 1, 2).beginning_of_day..Date.today.end_of_day) === user.orcid_expires_at
          Severity: Major
          Found in app/models/claim.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return OpenStruct.new(body: { "errors" => work.validation_errors.map { |error| { "title" => error } } }) if work.validation_errors.present?
            Severity: Major
            Found in app/models/claim.rb - About 30 mins to fix

              Method format_error_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def format_error_message(messages)
    Array.wrap(messages) do |msg|
      if msg["title"].is_a?(Hash) && msg.dig("title", "developer-message").present?
        title = msg.dig("title", "developer-message")
      elsif msg["title"].is_a?(String)
              Severity: Minor
              Found in app/models/claim.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      "claims-test"
              Severity: Major
              Found in app/models/claim.rb and 1 other location - About 4 hrs to fix
              app/models/user.rb on lines 141..177

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 162.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def self.import_by_ids(options = {})
    from_id = (options[:from_id] || Claim.minimum(:id)).to_i
    until_id = (options[:until_id] || Claim.maximum(:id)).to_i

    # get every id between from_id and end_id
              Severity: Minor
              Found in app/models/claim.rb and 1 other location - About 50 mins to fix
              app/models/user.rb on lines 128..137

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status