Sign upLogin

datacite/volpino

View on GitHub
Star

Showing 65 of 65 total issues

Method query has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    def query(query, options = {})
      aggregations = options[:totals_agg] == true ? totals_aggregations : get_aggregations_hash(options[:aggregations])
      options[:page] ||= {}
      options[:page][:number] ||= 1
      options[:page][:size] ||= 25
Severity: Minor
Found in app/models/concerns/indexable.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class User has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ApplicationRecord
  # include helper module for date and time calculations
  include Dateable

  # include helper module for DOI resolution
Severity: Minor
Found in app/models/user.rb - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      "claims-test"
    Severity: Major
    Found in app/models/claim.rb and 1 other location - About 4 hrs to fix
    app/models/user.rb on lines 141..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      "users-test"
    Severity: Major
    Found in app/models/user.rb and 1 other location - About 4 hrs to fix
    app/models/claim.rb on lines 318..354

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File user.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "orcid_client"

class User < ApplicationRecord
  # include helper module for date and time calculations
  include Dateable
    Severity: Minor
    Found in app/models/user.rb - About 3 hrs to fix

      Method index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def index
    sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "doi" then { "doi" => { order: "asc" } }
           when "-doi" then { "doi" => { order: "desc" } }
      Severity: Minor
      Found in app/controllers/claims_controller.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File indexable.rb has 302 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module Indexable
  extend ActiveSupport::Concern

  require "aws-sdk-sqs"
      Severity: Minor
      Found in app/models/concerns/indexable.rb - About 3 hrs to fix

        Method query has 78 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def query(query, options = {})
      aggregations = options[:totals_agg] == true ? totals_aggregations : get_aggregations_hash(options[:aggregations])
      options[:page] ||= {}
      options[:page][:number] ||= 1
      options[:page][:size] ||= 25
        Severity: Major
        Found in app/models/concerns/indexable.rb - About 3 hrs to fix

          Method index has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def index
    sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "doi" then { "doi" => { order: "asc" } }
           when "-doi" then { "doi" => { order: "desc" } }
          Severity: Major
          Found in app/controllers/claims_controller.rb - About 2 hrs to fix

            File claim.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require "nokogiri"
require "orcid_client"

class Claim < ApplicationRecord
  # include view helpers
            Severity: Minor
            Found in app/models/claim.rb - About 2 hrs to fix

              Method github has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                def github
    auth = request.env["omniauth.auth"]

    if current_user.present?
      @user = current_user
              Severity: Minor
              Found in app/controllers/users/omniauth_callbacks_controller.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method orcid has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                def orcid
    auth = request.env["omniauth.auth"]
    omniauth = flash[:omniauth] || {}

    if current_user.present?
              Severity: Minor
              Found in app/controllers/users/omniauth_callbacks_controller.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method page_from_params has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
              Open

                  def page_from_params(params)
      p = params.to_unsafe_h.dig(:page)

      page = if p.is_a?(Hash)
        p.symbolize_keys
              Severity: Minor
              Found in app/controllers/concerns/paginatable.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    sort = case params[:sort]
             when "relevance" then { "_score" => { order: "desc" } }
             when "doi" then { "doi" => { order: "asc" } }
             when "-doi" then { "doi" => { order: "desc" } }
             when "orcid" then { orcid: { order: "asc" } }
              Severity: Major
              Found in app/controllers/admin/claims_controller.rb and 1 other location - About 2 hrs to fix
              app/controllers/claims_controller.rb on lines 19..29

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "doi" then { "doi" => { order: "asc" } }
           when "-doi" then { "doi" => { order: "desc" } }
           when "orcid" then { orcid: { order: "asc" } }
              Severity: Major
              Found in app/controllers/claims_controller.rb and 1 other location - About 2 hrs to fix
              app/controllers/admin/claims_controller.rb on lines 42..52

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method collect_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                def collect_data(options = {})
    # user has not signed up yet or orcid_token is missing
    if user.blank? || orcid_token.blank?
      if ENV["NOTIFICATION_ACCESS_TOKEN"].present?
        response = notification.create_notification(options)
              Severity: Minor
              Found in app/models/claim.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method index has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def index
    sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "name" then { "family_name.raw" => { order: "asc" } }
           when "-name" then { "family_name.raw" => { order: "desc" } }
              Severity: Minor
              Found in app/controllers/users_controller.rb - About 1 hr to fix

                Method import_by_id has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
                Severity: Minor
                Found in app/models/claim.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method import_by_id has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
                Severity: Minor
                Found in app/models/user.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method github has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def github
    auth = request.env["omniauth.auth"]

    if current_user.present?
      @user = current_user
                Severity: Minor
                Found in app/controllers/users/omniauth_callbacks_controller.rb - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language