Sign upLogin

datacite/volpino

View on GitHub
Star
app/models/user.rb

Summary

Maintainability
D
2 days
Test Coverage
C
70%

Class User has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ApplicationRecord
  # include helper module for date and time calculations
  include Dateable

  # include helper module for DOI resolution
Severity: Minor
Found in app/models/user.rb - About 5 hrs to fix

    File user.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "orcid_client"

class User < ApplicationRecord
  # include helper module for date and time calculations
  include Dateable
    Severity: Minor
    Found in app/models/user.rb - About 3 hrs to fix

      Method import_by_id has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_by_id has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      Severity: Minor
      Found in app/models/user.rb - About 1 hr to fix

        Method parse_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_data(works, _options = {})
    Array(works).map do |work|
      work.extend Hashie::Extensions::DeepFetch
      doi = work.deep_fetch("external-ids", "external-id", 0, "external-id-value") { nil }
      claimed_at = get_iso8601_from_epoch(work.deep_fetch("last-modified-date", "value") { nil })
        Severity: Minor
        Found in app/models/user.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method delete_expired_token has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.delete_expired_token(index: nil)
    query = "orcid_expires_at:[1970-01-02 TO #{Date.today.strftime('%F')}]"

    response = User.query(query, index: index, page: { size: 1, cursor: [] })
    Rails.logger.info "#{response.results.total} Users with expired ORCID token found."
        Severity: Minor
        Found in app/models/user.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method push_github_identifier has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def push_github_identifier(options = {})
    # user has not linked github username
    return OpenStruct.new(body: { "skip" => true }) unless github_to_be_created? || github_to_be_deleted?

    # missing data raise errors
        Severity: Minor
        Found in app/models/user.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
      "users-test"
        Severity: Major
        Found in app/models/user.rb and 1 other location - About 4 hrs to fix
        app/models/claim.rb on lines 318..354

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 162.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def self.import_by_ids(options = {})
    from_id = (options[:from_id] || User.minimum(:id)).to_i
    until_id = (options[:until_id] || User.maximum(:id)).to_i

    # get every id between from_id and end_id
        Severity: Minor
        Found in app/models/user.rb and 1 other location - About 50 mins to fix
        app/models/claim.rb on lines 305..314

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status