Sign upLogin

datacite/volpino

View on GitHub
Star

Showing 65 of 65 total issues

Method index has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "name" then { "family_name.raw" => { order: "asc" } }
           when "-name" then { "family_name.raw" => { order: "desc" } }
Severity: Minor
Found in app/controllers/users_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_by_id has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
Severity: Minor
Found in app/models/user.rb - About 1 hr to fix

    Method import_by_id has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.import_by_id(options = {})
    return nil if options[:id].blank?

    id = options[:id].to_i
    index = if Rails.env.test?
    Severity: Minor
    Found in app/models/claim.rb - About 1 hr to fix

      Method orcid has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def orcid
    auth = request.env["omniauth.auth"]
    omniauth = flash[:omniauth] || {}

    if current_user.present?
      Severity: Minor
      Found in app/controllers/users/omniauth_callbacks_controller.rb - About 1 hr to fix

        Method load_index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def load_index
      sort = case params[:sort]
             when "relevance" then { "_score" => { order: "desc" } }
             when "doi" then { "doi" => { order: "asc" } }
             when "-doi" then { "doi" => { order: "desc" } }
        Severity: Minor
        Found in app/controllers/admin/claims_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function contributionsViz has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function contributionsViz(json, sources) {
  data = json.contributions;

  json.href = "?page={{number}}";
  if (source_id !== "") { json.href += "&source_id=" + source_id; }
        Severity: Minor
        Found in app/assets/javascripts/works/index.js - About 1 hr to fix

          Method orcid_work_type has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def orcid_work_type(internal_work_type, internal_work_subtype)
      type =  case internal_work_type
              when "Text"
                case internal_work_subtype
                when /^(Article|Articles|Journal Article|JournalArticle)$/i
          Severity: Minor
          Found in app/models/concerns/typeable.rb - About 1 hr to fix

            Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def initialize(user)
    user ||= User.new(role_id: "anonymous") # Guest user

    if user.role_id == "staff_admin"
      can :manage, :all
            Severity: Minor
            Found in app/models/ability.rb - About 1 hr to fix

              Method load_index has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def load_index
      sort = case params[:sort]
             when "relevance" then { "_score" => { order: "desc" } }
             when "doi" then { "doi" => { order: "asc" } }
             when "-doi" then { "doi" => { order: "desc" } }
              Severity: Minor
              Found in app/controllers/admin/claims_controller.rb - About 1 hr to fix

                Method process_data has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def process_data(options = {})
    start

    result = collect_data
                Severity: Minor
                Found in app/models/claim.rb - About 1 hr to fix

                  Method globus has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def globus
    auth = request.env["omniauth.auth"]

    if current_user.present?
      @user = current_user
                  Severity: Minor
                  Found in app/controllers/users/omniauth_callbacks_controller.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method serialize_errors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def serialize_errors(errors, options = {})
      return nil if errors.nil?

      errors_arr = []
                  Severity: Minor
                  Found in app/controllers/concerns/error_serializable.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      sort = case params[:sort]
           when "relevance" then { "_score" => { order: "desc" } }
           when "name" then { "family_name.raw" => { order: "asc" } }
           when "-name" then { "family_name.raw" => { order: "desc" } }
           when "created" then { created_at: { order: "asc" } }
                  Severity: Major
                  Found in app/controllers/users_controller.rb and 1 other location - About 1 hr to fix
                  app/controllers/admin/users_controller.rb on lines 48..54

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        sort = case params[:sort]
             when "relevance" then { "_score" => { order: "desc" } }
             when "name" then { "family_name.raw" => { order: "asc" } }
             when "-name" then { "family_name.raw" => { order: "desc" } }
             when "created" then { created_at: { order: "asc" } }
                  Severity: Major
                  Found in app/controllers/admin/users_controller.rb and 1 other location - About 1 hr to fix
                  app/controllers/users_controller.rb on lines 37..43

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method parse_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def parse_data(works, _options = {})
    Array(works).map do |work|
      work.extend Hashie::Extensions::DeepFetch
      doi = work.deep_fetch("external-ids", "external-id", 0, "external-id-value") { nil }
      claimed_at = get_iso8601_from_epoch(work.deep_fetch("last-modified-date", "value") { nil })
                  Severity: Minor
                  Found in app/models/user.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method process_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def process_data(options = {})
    start

    result = collect_data
                  Severity: Minor
                  Found in app/models/claim.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method orcid_work_type has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def orcid_work_type(internal_work_type, internal_work_subtype)
      type =  case internal_work_type
              when "Text"
                case internal_work_subtype
                when /^(Article|Articles|Journal Article|JournalArticle)$/i
                  Severity: Minor
                  Found in app/models/concerns/typeable.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method create_index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def create_index(options = {})
      alias_name = options[:alias] || index_name
      index_name = (options[:index] || self.index_name) + "_v1"
      alternate_index_name = (options[:index] || self.index_name) + "_v2"
      client = Elasticsearch::Model.client
                  Severity: Minor
                  Found in app/models/concerns/indexable.rb - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if @claim.save
        @claim.queue_claim_job

        options = {}
        options[:include] = @include
                  Severity: Minor
                  Found in app/controllers/claims_controller.rb and 1 other location - About 50 mins to fix
                  app/controllers/claims_controller.rb on lines 114..124

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 43.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if @claim.save
      @claim.queue_claim_job

      options = {}
      options[:include] = @include
                  Severity: Minor
                  Found in app/controllers/claims_controller.rb and 1 other location - About 50 mins to fix
                  app/controllers/claims_controller.rb on lines 133..143

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 43.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language