Sign upLogin

datahuborg/datahub

View on GitHub
Star

Showing 1,132 of 1,132 total issues

Function 14 has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

},{"./handlebars/base":14,"./handlebars/exception":15,"./handlebars/runtime":16,"./handlebars/safe-string":17,"./handlebars/utils":18}],14:[function(require,module,exports){
"use strict";
var Utils = require("./utils");
var Exception = require("./exception")["default"];
Severity: Minor
Found in src/browser/static/datatables/js/dataTables.extra.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in src/inventory/migrations/0011_make_collaborators_unique.py and 1 other location - About 2 hrs to fix
src/inventory/migrations/0009_make_card_names_unique.py on lines 0..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Severity: Major
Found in src/inventory/migrations/0009_make_card_names_unique.py and 1 other location - About 2 hrs to fix
src/inventory/migrations/0011_make_collaborators_unique.py on lines 0..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setOptions has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _Tether.prototype.setOptions = function(options, position) {
      var defaults, key, _i, _len, _ref1, _ref2;
      this.options = options;
      if (position == null) {
        position = true;
Severity: Major
Found in src/apps/dbwipes/static/js/lib/tether.js - About 2 hrs to fix

    Function setOptions has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _Tether.prototype.setOptions = function(options, position) {
      var defaults, key, _i, _len, _ref1, _ref2;
      this.options = options;
      if (position == null) {
        position = true;
    Severity: Major
    Found in src/browser/static/dbwipes/js/lib/tether.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      },{"hbsfy/runtime":20}],11:[function(require,module,exports){
// hbsfy compiled Handlebars template
var HandlebarsCompiler = require('hbsfy/runtime');
module.exports = HandlebarsCompiler.template({"compiler":[6,">= 2.0.0-beta.1"],"main":function(depth0,helpers,partials,data) {
    return "<div class=\"btn-group dropup\">\n  <button type=\"button\" class=\"dt-agg-button btn btn-primary dropdown-toggle dropup\" data-toggle=\"dropdown\" aria-expanded=\"false\">\n    <span class=\"dt-agg-type\">Aggregate... </span><span class=\"caret\"></span>\n  </button>\n  <ul class=\"dropdown-menu\" role=\"menu\">\n    <li><a class=\"dt-agg-item\" data-agg-type=\"count\">Count</a></li>\n    <li><a class=\"dt-agg-item\" data-agg-type=\"sum\">Sum</a></li>\n    <li><a class=\"dt-agg-item\" data-agg-type=\"avg\">Average</a></li>\n    <li><a class=\"dt-agg-item\" data-agg-type=\"min\">Min</a></li>\n    <li><a class=\"dt-agg-item\" data-agg-type=\"max\">Max</a></li>\n  </ul>\n</div>\n<div class=\"btn-group dropup dt-col-agg-div\" style=\"visibility:hidden\">\n  <button type=\"button\" class=\"dt-col-agg-button btn btn-primary dropdown-toggle dropup\" data-toggle=\"dropdown\" aria-expanded=\"false\">\n    <span class=\"dt-col-agg-name\">Column Name... </span><span class=\"caret\"></span>\n  </button>\n  <ul class=\"dropdown-menu dt-col-agg-list\" role=\"menu\">\n  </ul>\n</div>\n<span class=\"dt-agg-result \" style=\"visibility:hidden\">123</span>\n";
      Severity: Major
      Found in src/browser/static/datatables/js/dataTables.extra.js and 1 other location - About 2 hrs to fix
      src/browser/static/datatables/js/dataTables.extra.js on lines 541..548

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      },{"hbsfy/runtime":20}],10:[function(require,module,exports){
// hbsfy compiled Handlebars template
var HandlebarsCompiler = require('hbsfy/runtime');
module.exports = HandlebarsCompiler.template({"compiler":[6,">= 2.0.0-beta.1"],"main":function(depth0,helpers,partials,data) {
    return "<p>Shift-click columns for multi-sort.</p>\n<button class=\"btn btn-primary dt-new-filter\">New Filter</button>\n<label class=\"btn btn-primary\">\n  <input class=\"dt-invert-filter\" type=\"checkbox\" autocomplete=\"off\"> Invert Filter\n</label>\n\n";
      Severity: Major
      Found in src/browser/static/datatables/js/dataTables.extra.js and 1 other location - About 2 hrs to fix
      src/browser/static/datatables/js/dataTables.extra.js on lines 548..555

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function renderBrush has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          renderBrush: function(el) {
      if (el.select('.brush').size() > 0) {
        console.log(['qv.renderBrush', 'exists, skip']);
        return;
      }
      Severity: Major
      Found in src/browser/static/dbwipes/js/summary/queryview.js - About 2 hrs to fix

        Function renderBrush has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            renderBrush: function(el) {
      if (el.select('.brush').size() > 0) {
        console.log(['qv.renderBrush', 'exists, skip']);
        return;
      }
        Severity: Major
        Found in src/apps/dbwipes/static/js/summary/queryview.js - About 2 hrs to fix

          Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              Step.prototype.render = function() {
      var button, buttons, cfg, content, footer, header, link, paragraph, paragraphs, text, _i, _j, _len, _len1, _ref1, _ref2, _ref3;
      if (this.el != null) {
        this.destroy();
      }
          Severity: Minor
          Found in src/apps/dbwipes/static/js/lib/shepherd.js - About 2 hrs to fix

            Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                render: function() {
      this.$el.html(this.template(this.model.toDataJSON()));
      return this;
      var q = this.model.get('query'),
          xcol = q.get('x').col,
            Severity: Minor
            Found in src/apps/dbwipes/static/js/summary/tupleview.js - About 2 hrs to fix

              Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  render: function() {
      this.$el.html(this.template(this.model.toDataJSON()));
      return this;
      var q = this.model.get('query'),
          xcol = q.get('x').col,
              Severity: Minor
              Found in src/browser/static/dbwipes/js/summary/tupleview.js - About 2 hrs to fix

                Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    Step.prototype.render = function() {
      var button, buttons, cfg, content, footer, header, link, paragraph, paragraphs, text, _i, _j, _len, _len1, _ref1, _ref2, _ref3;
      if (this.el != null) {
        this.destroy();
      }
                Severity: Minor
                Found in src/browser/static/dbwipes/js/lib/shepherd.js - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  policies = self.find_table_policies(table[0][1],
                                                    table[0][0],
                                                    "select",
                                                    table[0][2])
                  Severity: Major
                  Found in src/core/db/query_rewriter.py and 1 other location - About 2 hrs to fix
                  src/core/db/query_rewriter.py on lines 174..175

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              policy = self.find_table_policies(
                table[0][1], table[0][0], "insert", table[0][2])
                  Severity: Major
                  Found in src/core/db/query_rewriter.py and 1 other location - About 2 hrs to fix
                  src/core/db/query_rewriter.py on lines 268..271

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Cyclomatic complexity is too high in function aggregate. (12)
                  Open

                  @login_required
def aggregate(request, repo, table, agg_type, col_name):
    username = request.user.get_username()
    manager = DataHubManager(username)
    repos = get_repos(manager)
                  Severity: Minor
                  Found in src/apps/datatables/views.py by radon

                  Cyclomatic Complexity

                  Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                  Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                  Construct Effect on CC Reasoning
                  if +1 An if statement is a single decision.
                  elif +1 The elif statement adds another decision.
                  else +0 The else statement does not cause a new decision. The decision is at the if.
                  for +1 There is a decision at the start of the loop.
                  while +1 There is a decision at the while statement.
                  except +1 Each except branch adds a new conditional path of execution.
                  finally +0 The finally block is unconditionally executed.
                  with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                  assert +1 The assert statement internally roughly equals a conditional statement.
                  Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                  Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                  Source: http://radon.readthedocs.org/en/latest/intro.html

                  Function position has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      position: function(_arg) {
      var abutted, addClasses, allClasses, bottom, height, left, right, side, sides, targetPos, top, width, _i, _j, _k, _l, _len, _len1, _len2, _len3, _ref1, _ref2, _ref3, _ref4, _ref5,
        _this = this;
      top = _arg.top, left = _arg.left;
      _ref1 = this.cache('element-bounds', function() {
                  Severity: Minor
                  Found in src/apps/dbwipes/static/js/lib/tether.js - About 1 hr to fix

                    Function position has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        position: function(_arg) {
      var abutted, addClasses, allClasses, bottom, height, left, right, side, sides, targetPos, top, width, _i, _j, _k, _l, _len, _len1, _len2, _len3, _ref1, _ref2, _ref3, _ref4, _ref5,
        _this = this;
      top = _arg.top, left = _arg.left;
      _ref1 = this.cache('element-bounds', function() {
                    Severity: Minor
                    Found in src/browser/static/dbwipes/js/lib/tether.js - About 1 hr to fix

                      Function setSelection has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          setSelection: function(clause) {
      function withinClause(clause, val) {
        if (clause == null) return false;
        if (util.isStr(clause.type)) {
          return _.contains(clause.vals, val);
                      Severity: Minor
                      Found in src/apps/dbwipes/static/js/summary/cstatview.js - About 1 hr to fix

                        Function setSelection has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            setSelection: function(clause) {
      function withinClause(clause, val) {
        if (clause == null) return false;
        if (util.isStr(clause.type)) {
          return _.contains(clause.vals, val);
                        Severity: Minor
                        Found in src/browser/static/dbwipes/js/summary/cstatview.js - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language