Sign upLogin

datahuborg/datahub

View on GitHub
Star

Showing 1,132 of 1,132 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for column in res:
            response_obj = {}
            response_obj['column_name'] = column[0]
            response_obj['data_type'] = column[1]
            columns.append(response_obj)
Severity: Major
Found in src/api/serializer.py and 1 other location - About 2 hrs to fix
src/api/serializer.py on lines 301..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for column in res:
            response_obj = {}
            response_obj['column_name'] = column[0]
            response_obj['data_type'] = column[1]
            response.append(response_obj)
Severity: Major
Found in src/api/serializer.py and 1 other location - About 2 hrs to fix
src/api/serializer.py on lines 253..257

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Cyclomatic complexity is too high in function scorpion_run. (14)
Open

def scorpion_run(db, requestdata, requestid):
  """
  badsel:  { alias: { x:, y:, xalias:, yalias:, } }
  goodsel: { alias: { x:, y:, xalias:, yalias:, } }
  """
Severity: Minor
Found in src/apps/dbwipes/scorpionutil.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method where_clause. (14)
Open

    def where_clause(self):
        # Figure out the types of the columns so we'll know whether to use
        # numeric operations or string operations.
        schema = self.manager.get_schema(self.repo, self.table)
        type_for_col = {}
Severity: Minor
Found in src/apps/datatables/util/run_draw_request.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

File test_api_endpoints.py has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django.core.urlresolvers import reverse
from rest_framework import status
from rest_framework.test import APITestCase
from django.contrib.auth.models import User
from core.db.manager import DataHubManager
Severity: Minor
Found in src/integration_tests/test_api_endpoints.py - About 2 hrs to fix

    Function setupScales has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setupScales: function(data) {
      var schema = this.model.get('schema'),
          xcol = this.model.get('x'),
          xalias = xcol.alias,
          ycols = this.model.get('ys'),
    Severity: Major
    Found in src/apps/dbwipes/static/js/summary/queryview.js - About 2 hrs to fix

      Function setupScales has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setupScales: function(data) {
      var schema = this.model.get('schema'),
          xcol = this.model.get('x'),
          xalias = xcol.alias,
          ycols = this.model.get('ys'),
      Severity: Major
      Found in src/browser/static/dbwipes/js/summary/queryview.js - About 2 hrs to fix

        Function 2 has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        },{"./aggregator.js":2,"./api.js":3,"./filter-bar.js":4,"./shorten-query.js":6,"./templates/table_header.hbs":12}],2:[function(require,module,exports){
var grouped_buttons_template = require("./templates/grouped-aggregate-dropdown.hbs");
var api = require("./api.js");
var col_list_items_template = require("./templates/aggregate-col-list-item.hbs");
var PostgresTypes = require("./postgres-types.js");
        Severity: Major
        Found in src/browser/static/datatables/js/dataTables.extra.js - About 2 hrs to fix

          Function where_to_sql has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

          def where_to_sql(where_json, negate=False):
    is_type = lambda s, types: any([t in s for t in types])
    l = []
    args = []
    for clause_json in where_json:
          Severity: Minor
          Found in src/apps/dbwipes/util.py - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function scorpion_run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

          def scorpion_run(db, requestdata, requestid):
  """
  badsel:  { alias: { x:, y:, xalias:, yalias:, } }
  goodsel: { alias: { x:, y:, xalias:, yalias:, } }
  """
          Severity: Minor
          Found in src/apps/dbwipes/scorpionutil.py - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function toWhereClause has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function toWhereClause(col, type, vals) {
    if (!vals || vals.length == 0) return null;
    var SQL = null;
    var re = new RegExp("'", "gi");
    if (isStr(type)) {
          Severity: Major
          Found in src/browser/static/dbwipes/js/summary/util.js - About 2 hrs to fix

            Function toWhereClause has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function toWhereClause(col, type, vals) {
    if (!vals || vals.length == 0) return null;
    var SQL = null;
    var re = new RegExp("'", "gi");
    if (isStr(type)) {
            Severity: Major
            Found in src/apps/dbwipes/static/js/summary/util.js - About 2 hrs to fix

              File summary.py has 258 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              from functools import wraps
import json

from core.db.manager import DataHubManager
              Severity: Minor
              Found in src/apps/dbwipes/summary.py - About 2 hrs to fix

                Function onResult has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    onResult: function(resp) {
      var _this = this;
      $(".scorpion-wait").hide();
      if (this.statusview) {
        this.statusview.state.running = false;
                Severity: Major
                Found in src/apps/dbwipes/static/js/summary/scorpionview.js - About 2 hrs to fix

                  Function onResult has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      onResult: function(resp) {
      var _this = this;
      $(".scorpion-wait").hide();
      if (this.statusview) {
        this.statusview.state.running = false;
                  Severity: Major
                  Found in src/browser/static/dbwipes/js/summary/scorpionview.js - About 2 hrs to fix

                    Function exports has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    module.exports = function(container, cd, dt) {
  var that = {};

  jqueryContainer = container;
  colDefs = cd;
                    Severity: Major
                    Found in src/apps/datatables/client/js/filter-bar.js - About 2 hrs to fix

                      Function build_query has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        window.DataQ.build_query = function(query) {

    // The list of columns to select.
    var select_list = [];
                      Severity: Major
                      Found in src/apps/dataq/client_src/js/dq-query-builder.js - About 2 hrs to fix

                        Function exports has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        module.exports = function(container, cd, dt) {
  var that = {};

  jqueryContainer = container;
  colDefs = cd;
                        Severity: Major
                        Found in src/browser/static/datatables/js/dataTables.extra.js - About 2 hrs to fix

                          File rlsmanager.py has 254 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          from collections import namedtuple

from config import settings
import os
import core.db.connection
                          Severity: Minor
                          Found in src/core/db/rlsmanager.py - About 2 hrs to fix

                            Function e has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                            Open

                            (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
                            Severity: Minor
                            Found in src/browser/static/datatables/js/dataTables.extra.js - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language