Sign upLogin

datahuborg/datahub

View on GitHub
Star
src/apps/dbwipes/summary.py

Summary

Maintainability
C
1 day
Test Coverage

File summary.py has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from functools import wraps
import json

from core.db.manager import DataHubManager
Severity: Minor
Found in src/apps/dbwipes/summary.py - About 2 hrs to fix

    Function get_columns_and_types has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_columns_and_types(self):
        manager = DataHubManager(user=self.username, repo_base=self.repo_base)

        tokens = self.tablename.split('.')
        repo = tokens[0]
    Severity: Minor
    Found in src/apps/dbwipes/summary.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_numeric_stats has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_numeric_stats(self, c):
        ndistinct = self.get_distinct_count(c)
        if ndistinct == 0:
            return []
        if ndistinct == 1:
    Severity: Minor
    Found in src/apps/dbwipes/summary.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, repo, tablename, username, repo_base=None,
    Severity: Minor
    Found in src/apps/dbwipes/summary.py - About 45 mins to fix

      Function get_date_stats has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_date_stats(self, col_name):
        q = ('select max(%s)::date, min(%s)::date, '
             'EXTRACT(EPOCH FROM (max(%s::timestamp) - min(%s::timestamp)))/60'
             ' as minutes from %s')
        q = q % (col_name, col_name, col_name, col_name, self.tablename)
      Severity: Minor
      Found in src/apps/dbwipes/summary.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function insert_into_cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def insert_into_cache(f):
    """Inserts metadata into the cache"""
    @wraps(f)
    def _f(self, *args, **kwargs):
        try:
      Severity: Minor
      Found in src/apps/dbwipes/summary.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def get_group_stats(self, col_name, groupby):
        q = ('select %s as GRP, min(%s), max(%s), count(*) '
             'from %s  %s group by GRP '
             'order by GRP limit %d')
        q = q % (groupby, col_name, col_name,
      Severity: Major
      Found in src/apps/dbwipes/summary.py and 1 other location - About 3 hrs to fix
      src/apps/dbwipes/summary.py on lines 287..300

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def get_char_stats(self, col_name):
        q = """
            select %s as GRP, min(%s), max(%s), count(*)
            FROM %s
            %s
      Severity: Major
      Found in src/apps/dbwipes/summary.py and 1 other location - About 3 hrs to fix
      src/apps/dbwipes/summary.py on lines 230..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status