Sign upLogin

datamolecule/door_mat

View on GitHub
Star
app/models/door_mat/access_token.rb

Summary

Maintainability
D
2 days
Test Coverage

Method has too many lines. [44/30]
Open

    def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
Severity: Minor
Found in app/models/door_mat/access_token.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class AccessToken has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class AccessToken < ActiveRecord::Base

    include DoorMat::AttrSymmetricStore

    belongs_to :actor, class_name: 'DoorMat::Actor'
Severity: Minor
Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

    Method create_from_params has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
    Severity: Minor
    Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method has too many lines. [39/30]
    Open

        def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
    Severity: Minor
    Found in app/models/door_mat/access_token.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Cyclomatic complexity for create_from_params is too high. [14/6]
    Open

        def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
    Severity: Minor
    Found in app/models/door_mat/access_token.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Cyclomatic complexity for validate_token is too high. [11/6]
    Open

        def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
    Severity: Minor
    Found in app/models/door_mat/access_token.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Cyclomatic complexity for swap_token! is too high. [10/6]
    Open

        def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
    Severity: Minor
    Found in app/models/door_mat/access_token.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method validate_token has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
    Severity: Minor
    Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_from_params has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
    Severity: Minor
    Found in app/models/door_mat/access_token.rb - About 1 hr to fix

      Method swap_token! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_token has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb - About 1 hr to fix

        Method swap_token! has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
        Severity: Minor
        Found in app/models/door_mat/access_token.rb - About 1 hr to fix

          Method create_from_params has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
          Severity: Major
          Found in app/models/door_mat/access_token.rb - About 50 mins to fix

            Method load_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.load_token(token, request, verbose=true)
      token = token.to_s.strip
      if DoorMat::Regex.session_guid.match(token).blank?
        DoorMat.configuration.logger.warn "WARN: #{request.remote_ip} Attempted to use token with invalid format #{token}" if verbose
        return nil
            Severity: Minor
            Found in app/models/door_mat/access_token.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return access_token
            Severity: Major
            Found in app/models/door_mat/access_token.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return access_token
              Severity: Major
              Found in app/models/door_mat/access_token.rb - About 30 mins to fix

                Avoid parameter lists longer than 5 parameters. [7/5]
                Open

                    def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
                Severity: Minor
                Found in app/models/door_mat/access_token.rb by rubocop

                This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

                end at 279, 6 is not aligned with case at 241, 21.
                Open

                      end
                Severity: Minor
                Found in app/models/door_mat/access_token.rb by rubocop

                This cop checks whether the end keywords are aligned properly.

                Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

                If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

                If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

                If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

                Example: EnforcedStyleAlignWith: keyword (default)

                # bad

variable = if true
    end

# good

variable = if true
           end

                Example: EnforcedStyleAlignWith: variable

                # bad

variable = if true
    end

# good

variable = if true
end

                Example: EnforcedStyleAlignWith: startofline

                # bad

variable = if true
    end

# good

puts(if true
end)

                There are no issues that match your filters.

                Category
                Status