Sign upLogin

datamolecule/door_mat

View on GitHub
Star

Showing 79 of 79 total issues

Method has too many lines. [49/30]
Open

    def initialize
      @mailer_from_address = "noreply@example.com"

      # Controllers that require_password_reconfirm will only
      # allow the user in without requesting an additional sign-in if the user password
Severity: Minor
Found in lib/door_mat/configuration.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class Session has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Session < ActiveRecord::Base

    belongs_to :actor
    belongs_to :email
Severity: Minor
Found in app/models/door_mat/session.rb - About 3 hrs to fix

    Method has too many lines. [44/30]
    Open

        def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
    Severity: Minor
    Found in app/models/door_mat/access_token.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method with has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.with(actor, new_password, old_password='', save_session=true)
        actor.with_lock do

          unless old_password.nil?
            return false unless actor.authenticate(old_password)
    Severity: Minor
    Found in lib/door_mat/process/actor_password_change.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class AccessToken has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class AccessToken < ActiveRecord::Base

    include DoorMat::AttrSymmetricStore

    belongs_to :actor, class_name: 'DoorMat::Actor'
    Severity: Minor
    Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

      Method has too many lines. [40/30]
      Open

            def self.with(actor, new_password, old_password='', save_session=true)
        actor.with_lock do

          unless old_password.nil?
            return false unless actor.authenticate(old_password)
      Severity: Minor
      Found in lib/door_mat/process/actor_password_change.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Method has too many lines. [40/30]
      Open

          def self.from(cookies, request)
      clear_current_session
      session_guid = cookies.encrypted[:session_guid].to_s.strip
      session_key = cookies.encrypted[:session_key].to_s.strip
      Severity: Minor
      Found in app/models/door_mat/session.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Method create_from_params has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
      Severity: Minor
      Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method has too many lines. [39/30]
      Open

          def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Cyclomatic complexity for create_from_params is too high. [14/6]
      Open

          def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
      Severity: Minor
      Found in app/models/door_mat/access_token.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Cyclomatic complexity for from is too high. [13/6]
      Open

          def self.from(cookies, request)
      clear_current_session
      session_guid = cookies.encrypted[:session_guid].to_s.strip
      session_key = cookies.encrypted[:session_key].to_s.strip
      Severity: Minor
      Found in app/models/door_mat/session.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Cyclomatic complexity for validate_token is too high. [11/6]
      Open

          def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          module ClassMethods

      def attr_asymmetric_store(*args, **options)
        return unless self.table_exists?
      Severity: Major
      Found in lib/door_mat/attr_asymmetric_store.rb and 1 other location - About 2 hrs to fix
      lib/door_mat/attr_symmetric_store.rb on lines 59..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          module ClassMethods

      def attr_symmetric_store(*args, **options)
        return unless self.table_exists?
      Severity: Major
      Found in lib/door_mat/attr_symmetric_store.rb and 1 other location - About 2 hrs to fix
      lib/door_mat/attr_asymmetric_store.rb on lines 59..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Cyclomatic complexity for swap_token! is too high. [10/6]
      Open

          def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Method validate_token has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
      Severity: Minor
      Found in app/models/door_mat/access_token.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Cyclomatic complexity for with is too high. [9/6]
      Open

            def self.with(actor, new_password, old_password='', save_session=true)
        actor.with_lock do

          unless old_password.nil?
            return false unless actor.authenticate(old_password)
      Severity: Minor
      Found in lib/door_mat/process/actor_password_change.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Method initialize has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize
      @mailer_from_address = "noreply@example.com"

      # Controllers that require_password_reconfirm will only
      # allow the user in without requesting an additional sign-in if the user password
      Severity: Minor
      Found in lib/door_mat/configuration.rb - About 1 hr to fix

        Method from has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.from(cookies, request)
      clear_current_session
      session_guid = cookies.encrypted[:session_guid].to_s.strip
      session_key = cookies.encrypted[:session_key].to_s.strip
        Severity: Minor
        Found in app/models/door_mat/session.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Cyclomatic complexity for process_token_request is too high. [8/6]
        Open

            def process_token_request(token_for, token, klass = DoorMat::AccessToken)
      klass.destroy_if_linked_to(cookies)
      @access_token = nil

      token_for_symbol = token_for.to_s.strip.to_sym
        Severity: Minor
        Found in app/controllers/door_mat/password_less_session_controller.rb by rubocop

        This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

        An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

        Severity
        Category
        Status
        Source
        Language