Sign upLogin

datamolecule/door_mat

View on GitHub
Star

Showing 79 of 79 total issues

Cyclomatic complexity for with is too high. [8/6]
Open

      def self.with(email, password, is_public, remember_me, request, cookies)
        # Destroy any session linked to existing cookies before
        # replacing it by a new session
        DoorMat::Session.destroy_if_linked_to(cookies)
Severity: Minor
Found in lib/door_mat/process/actor_sign_in.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for create is too high. [8/6]
Open

    def create
      before_sign_up
      @sign_up = DoorMat::SignUp.new(sign_up_params)
      sign_up_failed = true
Severity: Minor
Found in app/controllers/door_mat/sign_up_controller.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for with_session_for_actor is too high. [7/6]
Open

    def with_session_for_actor(actor)
      if self.valid? && (actor.nil? || self.actor_id.nil? || self.actor == actor)
        yield(self)
      elsif !actor.nil? && (sub_sessions.has_key? actor.id)
        yield(sub_sessions[actor.id])
Severity: Minor
Found in app/models/door_mat/session.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method create_from_params has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
      clear_current_access_token
      is_public = '1' == is_public.to_s
      remember_me = '1' == remember_me.to_s
Severity: Minor
Found in app/models/door_mat/access_token.rb - About 1 hr to fix

    Method with has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.with(actor, new_password, old_password='', save_session=true)
        actor.with_lock do

          unless old_password.nil?
            return false unless actor.authenticate(old_password)
    Severity: Minor
    Found in lib/door_mat/process/actor_password_change.rb - About 1 hr to fix

      Method from has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.from(cookies, request)
      clear_current_session
      session_guid = cookies.encrypted[:session_guid].to_s.strip
      session_key = cookies.encrypted[:session_key].to_s.strip
      Severity: Minor
      Found in app/models/door_mat/session.rb - About 1 hr to fix

        Method swap_token! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
        Severity: Minor
        Found in app/models/door_mat/access_token.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_token has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def self.validate_token(token, cookies, request)
      access_token = load_token(token, request)

      access_token = case
        when access_token.blank?
        Severity: Minor
        Found in app/models/door_mat/access_token.rb - About 1 hr to fix

          Method process_token_request has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def process_token_request(token_for, token, klass = DoorMat::AccessToken)
      klass.destroy_if_linked_to(cookies)
      @access_token = nil

      token_for_symbol = token_for.to_s.strip.to_sym
          Severity: Minor
          Found in app/controllers/door_mat/password_less_session_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def send_email_with(token, controller)
      parameters = {
          url: controller.send(:confirm_email_url, token: token, email: self.email.to_urlsafe_encoded, protocol: DoorMat::UrlProtocol.url_protocol),
          address: self.email.address
      }
          Severity: Major
          Found in app/models/door_mat/activity_confirm_email.rb and 1 other location - About 1 hr to fix
          app/models/door_mat/activity_reset_password.rb on lines 35..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def send_email_with(token, controller)
      parameters = {
          url: controller.send(:choose_new_password_url, token: token, email: self.email.to_urlsafe_encoded, protocol: DoorMat::UrlProtocol.url_protocol),
          address: self.email.address
      }
          Severity: Major
          Found in app/models/door_mat/activity_reset_password.rb and 1 other location - About 1 hr to fix
          app/models/door_mat/activity_confirm_email.rb on lines 33..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method with has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.with(email, password, is_public, remember_me, request, cookies)
        # Destroy any session linked to existing cookies before
        # replacing it by a new session
        DoorMat::Session.destroy_if_linked_to(cookies)
          Severity: Minor
          Found in lib/door_mat/process/actor_sign_in.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method swap_token! has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def self.swap_token!(cookies, valid_current_session_tokens, new_session_token, force_new_token_generation = false)
      access_token = current_access_token

      # Our current access token is in order
      return unless access_token.valid?
          Severity: Minor
          Found in app/models/door_mat/access_token.rb - About 1 hr to fix

            Method attr_symmetric_store has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def attr_symmetric_store(*args, **options)
        return unless self.table_exists?

        actor_column = options.fetch(:actor_column, :actor).to_s
        unless self.attribute_names.include? "#{actor_column}_id"
            Severity: Minor
            Found in lib/door_mat/attr_symmetric_store.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method attr_asymmetric_store has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def attr_asymmetric_store(*args, **options)
        return unless self.table_exists?

        actor_column = options.fetch(:actor_column, :actor).to_s
        unless self.attribute_names.include? "#{actor_column}_id"
            Severity: Minor
            Found in lib/door_mat/attr_asymmetric_store.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_from_params has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def self.create_from_params(token_for, identifier, confirm_identifier, name, is_public, remember_me, request)
            Severity: Major
            Found in app/models/door_mat/access_token.rb - About 50 mins to fix

              Method with has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def self.with(email, password, is_public, remember_me, request, cookies)
              Severity: Minor
              Found in lib/door_mat/process/actor_sign_in.rb - About 45 mins to fix

                Method around_save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                      def around_save(record)
        return yield if DoorMat::Crypto.current_skip_crypto_callback.skip?

        clear_attribute = record.send("#{@attribute}")
        actor = record.send("#{@actor_column}")
                Severity: Minor
                Found in lib/door_mat/attr_asymmetric_store.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method protected_by_password_less_session has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def protected_by_password_less_session(pls_symbols)
      pls_symbols = Array(pls_symbols)
      redirect_url = send("#{pls_symbols.first}_url".to_sym)

      if DoorMat::AccessToken.is_cookie_present? cookies
                Severity: Minor
                Found in lib/door_mat/controller.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method load_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def self.load_token(token, request, verbose=true)
      token = token.to_s.strip
      if DoorMat::Regex.session_guid.match(token).blank?
        DoorMat.configuration.logger.warn "WARN: #{request.remote_ip} Attempted to use token with invalid format #{token}" if verbose
        return nil
                Severity: Minor
                Found in app/models/door_mat/access_token.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language