Sign upLogin

datamolecule/door_mat

View on GitHub
Star
lib/door_mat/process/create_new_anonymous_actor.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method owned_by has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def self.owned_by(owner)
        password = DoorMat::Crypto::SymmetricStore.random_key
        anonymous_actor = Actor.create_with(password)
        return nil if anonymous_actor.blank?
Severity: Minor
Found in lib/door_mat/process/create_new_anonymous_actor.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

      rescue Exception => e
        DoorMat.configuration.logger.error "ERROR: CreateNewAnonymousActor failed to with error - #{e}"
        nil
Severity: Minor
Found in lib/door_mat/process/create_new_anonymous_actor.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

There are no issues that match your filters.

Category
Status