Sign upLogin

davidawad/lobe

View on GitHub
Star
app/messaging/fb_messenger.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function receive has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

def receive(data: dict):
    """
    Handler for webhook (currently for postback and messages)
    Parses out the message and bubbles it up to the processing layer
    """
Severity: Minor
Found in app/messaging/fb_messenger.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if not current_user:
                        current_user = User('fb', fb_id)
Severity: Major
Found in app/messaging/fb_messenger.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if lat:

                        current_user.add_coordinates(lat, long)

                        print("USER IN STATE : " + current_user.state)
    Severity: Major
    Found in app/messaging/fb_messenger.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status