davispeixoto/Force.com-Toolkit-for-PHP

View on GitHub
src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php

Summary

Maintainability
F
5 days
Test Coverage

File SforceBaseClient.php has 673 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Davispeixoto\ForceDotComToolkitForPhp;

    /*
     * Copyright (c) 2007, salesforce.com, inc.
     * All rights reserved.
Severity: Major
Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 1 day to fix

    SforceBaseClient has 63 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SforceBaseClient
    {
        protected $sforce;
        protected $sessionId;
        protected $location;
    Severity: Major
    Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 1 day to fix

      Function setHeaders has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          private function setHeaders($call = null)
          {
              $this->sforce->__setSoapHeaders(null);
      
              $header_array = array(
      Severity: Minor
      Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setHeaders has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function setHeaders($call = null)
          {
              $this->sforce->__setSoapHeaders(null);
      
              $header_array = array(
      Severity: Major
      Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 4 hrs to fix

        Function convertLead has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function convertLead($leadConverts)
            {
                $this->setHeaders("convertLead");
                $arg = new stdClass();
                
        Severity: Minor
        Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if ($call == "create" ||
                    $call == "merge" ||
                    $call == "query" ||
                    $call == "retrieve" ||
                    $call == "update" ||
        Severity: Major
        Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function sendMassEmail($request)
              {
                  if (is_array($request)) {
                      $messages = array();
                      foreach ($request as $r) {
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 584..601

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 146.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function sendSingleEmail($request)
              {
                  if (is_array($request)) {
                      $messages = array();
                      foreach ($request as $r) {
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 603..620

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 146.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function processWorkitemRequest($processRequestArray)
              {
                  if (is_array($processRequestArray)) {
                      foreach ($processRequestArray as &$process) {
                          $process = new SoapVar($process, SOAP_ENC_OBJECT, 'ProcessWorkitemRequest', $this->namespace);
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 713..728

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function processSubmitRequest($processRequestArray)
              {
                  if (is_array($processRequestArray)) {
                      foreach ($processRequestArray as &$process) {
                          $process = new SoapVar($process, SOAP_ENC_OBJECT, 'ProcessSubmitRequest', $this->namespace);
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 736..751

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 125.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getUpdated($type, $startDate, $endDate)
              {
                  $this->setHeaders("getUpdated");
                  $arg = new stdClass();
                  $arg->sObjectType = new SoapVar($type, XSD_STRING, 'string', 'http://www.w3.org/2001/XMLSchema');
          Severity: Minor
          Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 45 mins to fix
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 874..883

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function getDeleted($type, $startDate, $endDate)
              {
                  $this->setHeaders("getDeleted");
                  $arg = new stdClass();
                  $arg->sObjectType = new SoapVar($type, XSD_STRING, 'string', 'http://www.w3.org/2001/XMLSchema');
          Severity: Minor
          Found in src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php and 1 other location - About 45 mins to fix
          src/Davispeixoto/ForceDotComToolkitForPhp/SforceBaseClient.php on lines 894..903

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status