davispuh/TimezoneParser

View on GitHub

Showing 42 of 42 total issues

Method updateAbbreviations has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

        def self.updateAbbreviations(abbreviations)
            getLocales.each do |locale|
                tz = Cldr::Export::Data::Timezones.new(locale)
                next if tz.timezones.empty? and tz.metazones.empty?
                tz.timezones.each do |timezone, data|
Severity: Minor
Found in lib/timezone_parser/data/cldr.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAbbreviations has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

        def self.getAbbreviations
            transitionData = {}
            ::TZInfo::Timezone.all_data_zone_identifiers.each do |name|
                zone = ::TZInfo::Timezone.get(name)
                zone_transitions = zone.transitions_up_to(Time.at(LastTimestamp))
Severity: Minor
Found in lib/timezone_parser/data/tzinfo.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFilteredData has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

        def getFilteredData(dataType)
            types = nil
            types = [@Type] if @Type

            params = [@Abbreviation.downcase]
Severity: Minor
Found in lib/timezone_parser/abbreviation.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getTimezones has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

        def self.getTimezones
            timezones = { }
            getLocales.each do |locale|
                tz = Cldr::Export::Data::Timezones.new(locale)
                next if tz.timezones.empty? and tz.metazones.empty?
Severity: Minor
Found in lib/timezone_parser/data/cldr.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getMetazones has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

        def self.getMetazones
            zones = {}
            Cldr::Export::Data::Metazones.new[:timezones].each do |timezone, zonedata|
                zonedata.each do |data|
                    entry = {}
Severity: Minor
Found in lib/timezone_parser/data/cldr.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getFilteredData has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def getFilteredData(dataType)
            types = nil
            types = [@Type] if @Type

            params = [@Abbreviation.downcase]
Severity: Major
Found in lib/timezone_parser/abbreviation.rb - About 3 hrs to fix

    Method getFilteredData has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def getFilteredData(dataType)
                params = []
                column = nil
                joins = ''
                regionJoins = ''
    Severity: Major
    Found in lib/timezone_parser/timezone.rb - About 2 hrs to fix

      Method getAbbreviations has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.getAbbreviations
                  transitionData = {}
                  ::TZInfo::Timezone.all_data_zone_identifiers.each do |name|
                      zone = ::TZInfo::Timezone.get(name)
                      zone_transitions = zone.transitions_up_to(Time.at(LastTimestamp))
      Severity: Major
      Found in lib/timezone_parser/data/tzinfo.rb - About 2 hrs to fix

        Method getFilteredData has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

                def getFilteredData(dataType)
                    params = []
                    column = nil
                    joins = ''
                    regionJoins = ''
        Severity: Minor
        Found in lib/timezone_parser/timezone.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        tz.metazones.each do |metazone, data|
                            data[:short].to_a.each do |type, name|
                                next if name == '∅∅∅'
                                name = name.chomp.strip
                                type = type.to_s.encode(Encoding::UTF_8)
        Severity: Major
        Found in lib/timezone_parser/data/cldr.rb and 1 other location - About 2 hrs to fix
        lib/timezone_parser/data/cldr.rb on lines 110..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        tz.timezones.each do |timezone, data|
                            data[:short].to_a.each do |type, name|
                                next if name == '∅∅∅'
                                name = name.chomp.strip
                                type = type.to_s.encode(Encoding::UTF_8)
        Severity: Major
        Found in lib/timezone_parser/data/cldr.rb and 1 other location - About 2 hrs to fix
        lib/timezone_parser/data/cldr.rb on lines 134..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method getFilteredData has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def getFilteredData(dataType)
                    params = []
                    column = nil
                    joins = ''
                    regionJoins = ''
        Severity: Major
        Found in lib/timezone_parser/windows_zone.rb - About 2 hrs to fix

          Method parseMetazones has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

                  def self.parseMetazones(metazoneList, offsets, locales)
                      metazones = {}
                      metazoneList.each do |lcid, data|
                          locale = locales[lcid]
                          if locale.nil?
          Severity: Minor
          Found in lib/timezone_parser/data/windows.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method updateAbbreviations has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def self.updateAbbreviations(abbreviations)
                      getLocales.each do |locale|
                          tz = Cldr::Export::Data::Timezones.new(locale)
                          next if tz.timezones.empty? and tz.metazones.empty?
                          tz.timezones.each do |timezone, data|
          Severity: Major
          Found in lib/timezone_parser/data/cldr.rb - About 2 hrs to fix

            Method getFilteredData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                    def getFilteredData(dataType)
                        params = []
                        column = nil
                        joins = ''
                        regionJoins = ''
            Severity: Minor
            Found in lib/timezone_parser/windows_zone.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getFilteredData has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def getFilteredData(dataType)
                        params = []
                        column = nil
                        joins = ''
                        regionJoins = ''
            Severity: Minor
            Found in lib/timezone_parser/rails_zone.rb - About 1 hr to fix

              Method getTimezones has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def self.getTimezones
                          timezones = { }
                          getLocales.each do |locale|
                              tz = Cldr::Export::Data::Timezones.new(locale)
                              next if tz.timezones.empty? and tz.metazones.empty?
              Severity: Minor
              Found in lib/timezone_parser/data/cldr.rb - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        def isValid?
                            if @Valid.nil?
                                params = []
                                joins = ''
                                where = ''
                Severity: Major
                Found in lib/timezone_parser/windows_zone.rb and 2 other locations - About 1 hr to fix
                lib/timezone_parser/rails_zone.rb on lines 57..74
                lib/timezone_parser/timezone.rb on lines 58..75

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        def isValid?
                            if @Valid.nil?
                                params = []
                                joins = ''
                                where = ''
                Severity: Major
                Found in lib/timezone_parser/rails_zone.rb and 2 other locations - About 1 hr to fix
                lib/timezone_parser/timezone.rb on lines 58..75
                lib/timezone_parser/windows_zone.rb on lines 54..71

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        def isValid?
                            if @Valid.nil?
                                params = []
                                joins = ''
                                where = ''
                Severity: Major
                Found in lib/timezone_parser/timezone.rb and 2 other locations - About 1 hr to fix
                lib/timezone_parser/rails_zone.rb on lines 57..74
                lib/timezone_parser/windows_zone.rb on lines 54..71

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language