Sign upLogin

dblock/heroku-commander

View on GitHub
Star
lib/heroku/executor.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

      def run(cmd, options = {}, &block)
        lines = []
        running_pid = nil
        logger = options[:logger]
        logger.debug "Running: #{cmd}" if logger
Severity: Minor
Found in lib/heroku/executor.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run(cmd, options = {}, &block)
        lines = []
        running_pid = nil
        logger = options[:logger]
        logger.debug "Running: #{cmd}" if logger
Severity: Minor
Found in lib/heroku/executor.rb - About 1 hr to fix

    Method terminate_process! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def terminate_process!(pid, timeout)
          if timeout
            # Delay terminating of the process, usually to let the output flush.
            Thread.new(pid, timeout) do |pid, timeout|
              begin
    Severity: Minor
    Found in lib/heroku/executor.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read_from has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def read_from(r, pid, options, lines, &block)
    Severity: Minor
    Found in lib/heroku/executor.rb - About 35 mins to fix

      Method read_from has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def read_from(r, pid, options, lines, &block)
          logger = options[:logger]
          while ! r.eof do
            line = r.readline
            line.strip! if line
      Severity: Minor
      Found in lib/heroku/executor.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status