Sign upLogin

dblock/slack-gamebot

View on GitHub
Star
slack-gamebot/models/challenge.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Challenge has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Challenge
  include Mongoid::Document
  include Mongoid::Timestamps

  index(state: 1, channel: 1)
Severity: Minor
Found in slack-gamebot/models/challenge.rb - About 2 hrs to fix

    Method validate_unique_challenge has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_unique_challenge
    return unless state == ChallengeState::PROPOSED || state == ChallengeState::ACCEPTED

    (challengers + challenged).each do |player|
      existing_challenge = ::Challenge.find_by_user(team, channel, player)
    Severity: Minor
    Found in slack-gamebot/models/challenge.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_updated_by has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_updated_by
    case state
    when ChallengeState::ACCEPTED
      return if updated_by && challenged.include?(updated_by)
    Severity: Minor
    Found in slack-gamebot/models/challenge.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_from_teammates_and_opponents has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def self.new_from_teammates_and_opponents(client, channel, challenger, names, separator = 'with')
    Severity: Minor
    Found in slack-gamebot/models/challenge.rb - About 35 mins to fix

      Method create_from_teammates_and_opponents! has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.create_from_teammates_and_opponents!(client, channel, challenger, names, separator = 'with')
      Severity: Minor
      Found in slack-gamebot/models/challenge.rb - About 35 mins to fix

        Method draw! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def draw!(player, scores = nil)
    raise SlackGamebot::Error, 'Challenge must first be accepted.' if state == ChallengeState::PROPOSED
    raise SlackGamebot::Error, "Challenge has already been #{state}." unless state == ChallengeState::ACCEPTED || state == ChallengeState::DRAWN
    raise SlackGamebot::Error, "Already recorded a draw from #{player.user_name}." if draw.include?(player)
        Severity: Minor
        Found in slack-gamebot/models/challenge.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def resign!(loser, scores = nil)
    raise SlackGamebot::Error, 'Challenge must first be accepted.' if state == ChallengeState::PROPOSED
    raise SlackGamebot::Error, "Challenge has already been #{state}." unless state == ChallengeState::ACCEPTED

    winners, losers = winners_and_losers_for_resigned(loser)
        Severity: Major
        Found in slack-gamebot/models/challenge.rb and 1 other location - About 1 hr to fix
        slack-gamebot/models/challenge.rb on lines 99..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def lose!(loser, scores = nil)
    raise SlackGamebot::Error, 'Challenge must first be accepted.' if state == ChallengeState::PROPOSED
    raise SlackGamebot::Error, "Challenge has already been #{state}." unless state == ChallengeState::ACCEPTED

    winners, losers = winners_and_losers_for(loser)
        Severity: Major
        Found in slack-gamebot/models/challenge.rb and 1 other location - About 1 hr to fix
        slack-gamebot/models/challenge.rb on lines 118..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def winners_and_losers_for_resigned(loser)
    if challenged.include?(loser)
      [challengers, challenged]
    elsif challengers.include?(loser)
      [challenged, challengers]
        Severity: Minor
        Found in slack-gamebot/models/challenge.rb and 1 other location - About 25 mins to fix
        slack-gamebot/models/challenge.rb on lines 108..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def winners_and_losers_for(loser)
    if challenged.include?(loser)
      [challengers, challenged]
    elsif challengers.include?(loser)
      [challenged, challengers]
        Severity: Minor
        Found in slack-gamebot/models/challenge.rb and 1 other location - About 25 mins to fix
        slack-gamebot/models/challenge.rb on lines 127..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status