Sign upLogin

dbudwin/RoboHome-Web

View on GitHub
Star
app/Http/Controllers/API/DevicesController.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using App\Http\Controllers\API\count() function in for loops.
Open

        for ($i = 0; $i < count($devicesForCurrentUser); $i++) {
            $appliance = [
                'actions' => $actions,
                'additionalApplianceDetails' => (object)[],
                'applianceId' => $devicesForCurrentUser[$i]->id,
Severity: Minor
Found in app/Http/Controllers/API/DevicesController.php by phpmd

CountInLoopExpression

Since: 2.7.0

Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

Example

class Foo {

  public function bar()
  {
    $array = array();

    for ($i = 0; count($array); $i++) {
      // ...
    }
  }
}

Source https://phpmd.org/rules/design.html#countinloopexpression

Line exceeds 120 characters; contains 154 characters
Open

    public function __construct(IDeviceRepository $deviceRepository, IDeviceActionInfoBroker $deviceInformationBroker, MessagePublisher $messagePublisher)
Severity: Minor
Found in app/Http/Controllers/API/DevicesController.php by phpcodesniffer

Line exceeds 120 characters; contains 135 characters
Open

            'header' => $this->createHeader($request, DeviceActions::actionToConfirmationName($action), 'Alexa.ConnectedHome.Control'),
Severity: Minor
Found in app/Http/Controllers/API/DevicesController.php by phpcodesniffer

There are no issues that match your filters.

Category
Status