dbudwin/RoboHome-Web

DevicesControllerTest has 32 functions (exceeds 20 allowed). Consider refactoring.

Open

class DevicesControllerTest extends DevicesControllerTestCase
{
    public function testDevices_GivenUserNotLoggedIn_RedirectToLogin(): void
    {
        $response = $this->get('/devices');

The class DevicesControllerTest has 32 non-getter- and setter-methods. Consider refactoring DevicesControllerTest to keep number of methods under 25.

Open

class DevicesControllerTest extends DevicesControllerTestCase
{
    public function testDevices_GivenUserNotLoggedIn_RedirectToLogin(): void
    {
        $response = $this->get('/devices');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class DevicesControllerTest has 20 public methods. Consider refactoring DevicesControllerTest to keep number of public methods under 10.

Open

class DevicesControllerTest extends DevicesControllerTestCase
{
    public function testDevices_GivenUserNotLoggedIn_RedirectToLogin(): void
    {
        $response = $this->get('/devices');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class DevicesTest has 13 public methods. Consider refactoring DevicesTest to keep number of public methods under 10.

Open

class DevicesTest extends DuskTestCase
{
    private $user;

    public function setUp(): void

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The class DeviceRepositoryTest has 12 public methods. Consider refactoring DeviceRepositoryTest to keep number of public methods under 10.

Open

class DeviceRepositoryTest extends RepositoryTestCaseWithRealDatabase
{
    private $deviceRepository;

    public function setUp(): void

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File DevicesControllerTest.php has 291 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

namespace Tests\Unit\Controller\Web;

use App\Device;

DevicesControllerTest has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

class DevicesControllerTest extends DevicesControllerTestCase
{
    private $mockDeviceRepository;
    private $mockUser;
    private $messageId;

Avoid excessively long variable names like $htmlDataAttributesForSpecificDeviceProperties. Keep variable name length under 35.

Open

        $htmlDataAttributesForSpecificDeviceProperties = [];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Method testDevices_GivenUserLoggedIn_EditsDevice_DevicesUpdatedOnPage has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function testDevices_GivenUserLoggedIn_EditsDevice_DevicesUpdatedOnPage(): void
    {
        $this->browse(function (Browser $browser) {
            $deviceName = self::$faker->word();
            $deviceDescription = self::$faker->sentence();

Method testDevices_GivenUserLoggedIn_ClicksEditDeviceButton_OpensEditDeviceModal has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function testDevices_GivenUserLoggedIn_ClicksEditDeviceButton_OpensEditDeviceModal(): void
    {
        $this->browse(function (Browser $browser) {
            $deviceName = self::$faker->word();
            $deviceDescription = self::$faker->sentence();

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class DatabaseSeeder extends Seeder

• Exclude checks
  • Disable engine
  • Disable check

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first side effect is on line 24.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $mockDeviceRepository
            ->shouldReceive('name')->once()->with($deviceId)
            ->shouldReceive('getForPublicId')->with(Mockery::on(function (Uuid $argument) use ($publicDeviceId) {
                return $argument instanceof Uuid && $argument == Uuid::import($publicDeviceId);
            }))->once()->andReturn($device)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $mockDeviceRepository
            ->shouldReceive('name')->never()->with($deviceId)
            ->shouldReceive('getForPublicId')->with(Mockery::on(function (Uuid $argument) use ($publicDeviceId) {
                return $argument instanceof Uuid && $argument == Uuid::import($publicDeviceId);
            }))->once()->andReturn($device)

• Read up
  Read up

Method loginAndAddDevice has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private function loginAndAddDevice(Browser $browser, string $deviceName, string $deviceDescription, int $onCode, int $offCode, int $pulseLength) : Browser

Each class must be in a file by itself

Open

class FakeDeviceModel extends Model

• Exclude checks
  • Disable engine
  • Disable check

The method createDevice has a boolean flag argument $isOwnedByUser, which is a certain sign of a Single Responsibility Principle violation.

Open

    private function createDevice(bool $isOwnedByUser = true): Device

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method mockMessagePublisher has a boolean flag argument $messagePublishedSuccessfully, which is a certain sign of a Single Responsibility Principle violation.

Open

    protected function mockMessagePublisher(int $timesPublishIsCalled, bool $messagePublishedSuccessfully = true): void

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Missing class import via use statement (line '86', column '33').

Open

        $deviceTypesClass = new \ReflectionClass(DeviceTypes::class);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

The method callDeleteOnDeviceUserOwns has a boolean flag argument $wasDeleteSuccessful, which is a certain sign of a Single Responsibility Principle violation.

Open

    private function callDeleteOnDeviceUserOwns(bool $wasDeleteSuccessful = true): TestResponse

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}