Sign upLogin

deparkes/OOMMFTools

View on GitHub
Star

Showing 74 of 74 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        tsizer.Add(rlbsizer, 1, wx.ALIGN_CENTER | wx.EXPAND | wx.LEFT | wx.RIGHT, 10)
Severity: Major
Found in oommftools/user_interfaces/gui/odtchomp.py and 3 other locations - About 1 hr to fix
oommftools/user_interfaces/gui/odtchomp.py on lines 126..126
oommftools/user_interfaces/gui/oommfconvert.py on lines 248..248
oommftools/user_interfaces/gui/oommfdecode.py on lines 119..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        sizer.Add(ins, 0, wx.ALIGN_CENTER | wx.ALIGN_CENTER_VERTICAL | wx.BOTTOM | wx.TOP, 60)
Severity: Major
Found in oommftools/user_interfaces/gui/oommfconvert.py and 3 other locations - About 1 hr to fix
oommftools/user_interfaces/gui/odtchomp.py on lines 126..126
oommftools/user_interfaces/gui/odtchomp.py on lines 172..172
oommftools/user_interfaces/gui/oommfdecode.py on lines 119..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        sizer.Add(ins, 0, wx.ALIGN_CENTER | wx.ALIGN_CENTER_VERTICAL | wx.BOTTOM | wx.TOP, 80)
Severity: Major
Found in oommftools/user_interfaces/gui/oommfdecode.py and 3 other locations - About 1 hr to fix
oommftools/user_interfaces/gui/odtchomp.py on lines 126..126
oommftools/user_interfaces/gui/odtchomp.py on lines 172..172
oommftools/user_interfaces/gui/oommfconvert.py on lines 248..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        self.OOMMFPathLabel = wx.StaticText(panel, -1, "OOMMF not located.", style = wx.ALIGN_CENTER | wx.ST_NO_AUTORESIZE | wx.ALIGN_CENTER_VERTICAL)
Severity: Minor
Found in oommftools/user_interfaces/gui/oommfconvert.py and 1 other location - About 55 mins to fix
oommftools/user_interfaces/gui/oommfconvert.py on lines 157..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function gatherData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def gatherData(self, data, headers, extraData):
        """
        """
        global LASTPATH
        #Outputs are array, headers, filenam
Severity: Minor
Found in oommftools/user_interfaces/gui/oommfdecode.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        self.ConfPathLabel = wx.StaticText(panel, -1, "No config loaded.", style = wx.EXPAND | wx.ALIGN_CENTER | wx.ST_NO_AUTORESIZE)
Severity: Minor
Found in oommftools/user_interfaces/gui/oommfconvert.py and 1 other location - About 55 mins to fix
oommftools/user_interfaces/gui/oommfconvert.py on lines 132..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function makeMovieFromImages has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def makeMovieFromImages(moviePath, pathTo, maxDigits, movieCodec, stdinRedirect, codecs, mode='advanced'):
Severity: Major
Found in oommftools/core/oommfconvert.py - About 50 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if grab:
                        log("Indexing %s at point %d" % (grab, len(retHeaders)))
                        retHeaders.append(grab)
                        if not grab in retDict:
                            log("Identifying new header: %s" % grab)
    Severity: Major
    Found in oommftools/core/odtchomp.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if line[0] == "{":
                        #Group match!
                        grab, line = line.split("}", 1)
                        line = line.strip() #Must clear trailing spaces
                        grab = grab.strip("{}")
      Severity: Major
      Found in oommftools/core/odtchomp.py - About 45 mins to fix

        Function _binaryDecode has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _binaryDecode(filehandle, chunksize, decoder, targetarray, headers, extraCaptures):
        Severity: Minor
        Found in oommftools/core/oommfdecode.py - About 45 mins to fix

          Function convertOmfToImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def convertOmfToImage(omf, tclCall, oommfPath, confpath, stdinRedirect, mode='advanced'):
          Severity: Minor
          Found in oommftools/core/oommfconvert.py - About 45 mins to fix

            Function write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def write(filename, interpreter, delim, fields):
    """
    """
    print("Write out to:", filename)
    refdelim = delim
            Severity: Minor
            Found in oommftools/core/odtchomp.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                def onClose(self, evt):
        """
        """
        if self.manager:
            self.manager.droppedWindow(self)
            Severity: Minor
            Found in oommftools/user_interfaces/gui/oommfdecode.py and 1 other location - About 40 mins to fix
            oommftools/user_interfaces/gui/odtchomp.py on lines 217..222

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                def onClose(self, evt):
        """
        """
        if self.manager:
            self.manager.droppedWindow(self)
            Severity: Minor
            Found in oommftools/user_interfaces/gui/odtchomp.py and 1 other location - About 40 mins to fix
            oommftools/user_interfaces/gui/oommfdecode.py on lines 168..173

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function doImages has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def doImages(targetList, stdinRedirect, config_parent, tclCall, OOMMFPath):
            Severity: Minor
            Found in oommftools/core/oommfconvert.py - About 35 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  def makeConvert(self, evt):
        """Open oommfconvert window
        """
        if not self.oommfconvert:
            self.oommfconvert = oommfconvert.MainFrame(self)
              Severity: Minor
              Found in oommftools/user_interfaces/gui/main.py and 2 other locations - About 35 mins to fix
              oommftools/user_interfaces/gui/main.py on lines 76..80
              oommftools/user_interfaces/gui/main.py on lines 88..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      imageConfig = {'magnifierSpin': self.parent.magnifierSpin.GetValue(),
                       'autoMaxVectors': self.parent.autoMaxVectors.GetValue(),
                       'config': self.parent.config}
              Severity: Minor
              Found in oommftools/user_interfaces/gui/oommfconvert.py and 1 other location - About 35 mins to fix
              oommftools/user_interfaces/gui/oommfconvert.py on lines 444..446

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      imageConfig = {'magnifierSpin': self.parent.magnifierSpin.GetValue(),
                       'autoMaxVectors': self.parent.autoMaxVectors.GetValue(),
                       'config': self.parent.config}
              Severity: Minor
              Found in oommftools/user_interfaces/gui/oommfconvert.py and 1 other location - About 35 mins to fix
              oommftools/user_interfaces/gui/oommfconvert.py on lines 434..436

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  confpath, cleanconfig = resolveConfiguration(targetList, 
                                                 config_parent['magnifierSpin'],
                                                 config_parent['autoMaxVectors'],
                                                 config_parent['config'])
              Severity: Minor
              Found in oommftools/core/oommfconvert.py and 1 other location - About 35 mins to fix
              oommftools/core/oommfconvert.py on lines 191..194

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function OnDropFiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def OnDropFiles(self, x, y, filenames):
        """
        """
        namepotential = filterOnExtensions(["odt"], filenames)
        if not self.parent.batchModeCheckbox.GetValue() or not self.parent.digest:
              Severity: Minor
              Found in oommftools/user_interfaces/gui/odtchomp.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language