Sign upLogin

detain/myadmin-licenses-module

View on GitHub
Star

Showing 125 of 125 total issues

Function api_buy_license has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
Severity: Minor
Found in src/api.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method api_buy_license has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
Severity: Major
Found in src/api.php - About 1 day to fix

    File api.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
* API License Functions
*
* @author Joe Huss <detain@interserver.net>
    Severity: Minor
    Found in src/api.php - About 6 hrs to fix

      Method api_cancel_license_ip has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function api_cancel_license_ip($sid, $ip, $service_type)
{
    $service_type = (int)$service_type;
    myadmin_log('api', 'info', "api_cancel_license_ip('{$sid}', '{$ip}', {$service_type}) called", __LINE__, __FILE__);
    $module = 'licenses';
      Severity: Major
      Found in src/api.php - About 2 hrs to fix

        Method api_change_license_ip has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function api_change_license_ip($sid, $oldip, $newip)
{
    $GLOBALS['tf']->session->sessionid = $sid;
    $module = 'licenses';
    $settings = get_module_settings($module);
        Severity: Minor
        Found in src/api.php - About 1 hr to fix

          Avoid excessively long variable names like $prepay_low_funds_triggers_error. Keep variable name length under 20.
          Open

                  $prepay_low_funds_triggers_error = false;
          Severity: Minor
          Found in src/api.php by phpmd

          LongVariable

          Since: 0.2

          Detects when a field, formal or local variable is declared with a long name.

          Example

          class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

          Source https://phpmd.org/rules/naming.html#longvariable

          Method api_change_license_ip_by_id has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function api_change_license_ip_by_id($sid, $id, $newip)
{
    $id = (int)$id;
    $GLOBALS['tf']->session->sessionid = $sid;
    $module = 'licenses';
          Severity: Minor
          Found in src/api.php - About 1 hr to fix

            Function api_cancel_license_ip has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function api_cancel_license_ip($sid, $ip, $service_type)
{
    $service_type = (int)$service_type;
    myadmin_log('api', 'info', "api_cancel_license_ip('{$sid}', '{$ip}', {$service_type}) called", __LINE__, __FILE__);
    $module = 'licenses';
            Severity: Minor
            Found in src/api.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method api_cancel_license has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function api_cancel_license($sid, $id)
{
    $module = 'licenses';
    $id = (int)$id;
    $db = get_module_db($module);
            Severity: Minor
            Found in src/api.php - About 1 hr to fix

              Method loadProcessing has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function loadProcessing(GenericEvent $event)
    {
        /**
         * @var \ServiceHandler $service
         */
              Severity: Minor
              Found in src/Plugin.php - About 1 hr to fix

                Avoid using undefined variables such as '$temp_service_ids' which will lead to PHP notices.
                Open

                            $service_id_for_type = implode(',', $temp_service_ids);
                Severity: Minor
                Found in src/api.php by phpmd

                UndefinedVariable

                Since: 2.8.0

                Detects when a variable is used that has not been defined before.

                Example

                class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

                Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                Avoid using undefined variables such as '$temp_service_ids' which will lead to PHP notices.
                Open

                                    $temp_service_ids[] = $db->Record['services_id'];
                Severity: Minor
                Found in src/api.php by phpmd

                UndefinedVariable

                Since: 2.8.0

                Detects when a variable is used that has not been defined before.

                Example

                class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

                Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                The parameter $use_prepay is not named in camelCase.
                Open

                function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
                Severity: Minor
                Found in src/api.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $service_type is not named in camelCase.
                Open

                function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
                Severity: Minor
                Found in src/api.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $use_prepay is not named in camelCase.
                Open

                function api_buy_license_prepay($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    return api_buy_license($sid, $ip, $service_type, $coupon, $use_prepay);
}
                Severity: Minor
                Found in src/api.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $service_type is not named in camelCase.
                Open

                function api_cancel_license_ip($sid, $ip, $service_type)
{
    $service_type = (int)$service_type;
    myadmin_log('api', 'info', "api_cancel_license_ip('{$sid}', '{$ip}', {$service_type}) called", __LINE__, __FILE__);
    $module = 'licenses';
                Severity: Minor
                Found in src/api.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                The parameter $service_type is not named in camelCase.
                Open

                function api_buy_license_prepay($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    return api_buy_license($sid, $ip, $service_type, $coupon, $use_prepay);
}
                Severity: Minor
                Found in src/api.php by phpmd

                CamelCaseParameterName

                Since: 0.2

                It is considered best practice to use the camelCase notation to name parameters.

                Example

                class ClassName {
    public function doSomething($user_name) {
    }
}

                Source

                Function api_change_license_ip has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function api_change_license_ip($sid, $oldip, $newip)
{
    $GLOBALS['tf']->session->sessionid = $sid;
    $module = 'licenses';
    $settings = get_module_settings($module);
                Severity: Minor
                Found in src/api.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method api_buy_license_prepay has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function api_buy_license_prepay($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
                Severity: Minor
                Found in src/api.php - About 35 mins to fix

                  Method api_buy_license has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
                  Severity: Minor
                  Found in src/api.php - About 35 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language