Sign upLogin

detain/myadmin-licenses-module

View on GitHub
Star

Showing 125 of 125 total issues

Function api_change_license_ip_by_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function api_change_license_ip_by_id($sid, $id, $newip)
{
    $id = (int)$id;
    $GLOBALS['tf']->session->sessionid = $sid;
    $module = 'licenses';
Severity: Minor
Found in src/api.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return $return;
Severity: Major
Found in src/api.php - About 30 mins to fix

    Missing class import via use statement (line '380', column '14').
    Open

            (new \MyAdmin\Mail())->multiMail($subject, $msg, $data['account_lid'], 'client/license_paytoactivate.tpl');
    Severity: Minor
    Found in src/api.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '129', column '31').
    Open

                    $smarty = new \TFSmarty();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '134', column '22').
    Open

                    (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/license_reactivated.tpl');
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid too many return statements within this method.
    Open

            return $return;
    Severity: Major
    Found in src/api.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $return;
      Severity: Major
      Found in src/api.php - About 30 mins to fix

        Missing class import via use statement (line '373', column '23').
        Open

                $smarty = new TFSmarty();
        Severity: Minor
        Found in src/api.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '121', column '22').
        Open

                        (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/license_created.tpl');
        Severity: Minor
        Found in src/Plugin.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Avoid too many return statements within this method.
        Open

            return $return;
        Severity: Major
        Found in src/api.php - About 30 mins to fix

          Missing class import via use statement (line '115', column '31').
          Open

                          $smarty = new \TFSmarty();
          Severity: Minor
          Found in src/Plugin.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Avoid too many return statements within this method.
          Open

                  return $return;
          Severity: Major
          Found in src/api.php - About 30 mins to fix

            Missing class import via use statement (line '337', column '31').
            Open

                    $repeat_invoice = new \MyAdmin\Orm\Repeat_Invoice($db);
            Severity: Minor
            Found in src/api.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
    return new \stdClass();
}

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Avoid unused local variables such as '$paid'.
            Open

                $paid = false;
            Severity: Minor
            Found in src/api.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            The variable $prepay_low_funds_triggers_error is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            The variable $service_type is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            The variable $service_id_for_type is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            The variable $service_cost is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            The variable $int_map is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            The variable $service_types is not named in camelCase.
            Open

            function api_buy_license($sid, $ip, $service_type, $coupon = '', $use_prepay = null)
{
    if (null === $use_prepay) {
        $use_prepay = true;
        $prepay_low_funds_triggers_error = false;
            Severity: Minor
            Found in src/api.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

            Source

            Severity
            Category
            Status
            Source
            Language