Sign upLogin

dfcreative/color

View on GitHub
Star

Showing 11 of 11 total issues

File index.js has 339 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Barebones color class.
 *
 * @module color
 */
Severity: Minor
Found in index.js - About 4 hrs to fix

    Function defineSpace has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    proto.defineSpace = function (name, space) {
    //create precisions
    space.precision = space.channel.map(function (ch, idx) {
        return Math.abs(space.max[idx] - space.min[idx]) > 1 ? 1 : 0.01;
    });
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function from has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      proto.parse = proto.from = function (arg, space) {
    var self = this;

    if (!arg) {
        return self;
      Severity: Minor
      Found in index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fromJSON has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      proto.fromJSON = function (obj, spaceName) {
    var space;

    if (spaceName) {
        space = spaces[spaceName];
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        proto.values = function () {
    if (arguments.length) {
        return this.setValues.apply(this, arguments);
    }
    return this.getValues.apply(this, arguments);
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 299..304

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        proto.space = function () {
    if (arguments.length) {
        return this.setSpace.apply(this, arguments);
    }
    return this.getSpace.apply(this, arguments);
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 268..273

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        proto.percentString = function (str) {
    if (arguments.length) {
        return this.fromString(str, 'percent');
    }
    else {
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 463..470

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        proto.keyword = function (str) {
    if (arguments.length) {
        return this.fromString(str, 'keyword');
    }
    else {
        Severity: Major
        Found in index.js and 1 other location - About 1 hr to fix
        index.js on lines 452..459

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function from has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        proto.parse = proto.from = function (arg, space) {
    var self = this;

    if (!arg) {
        return self;
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function defineSpace has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          proto.defineSpace = function (name, space) {
    //create precisions
    space.precision = space.channel.map(function (ch, idx) {
        return Math.abs(space.max[idx] - space.min[idx]) > 1 ? 1 : 0.01;
    });
          Severity: Minor
          Found in index.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function toArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          proto.toArray = function (space) {
    var values;

    if (!space) {
        space = this._space;
          Severity: Minor
          Found in index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language