dfcreative/gauge

View on GitHub

Showing 28 of 28 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

proto.values = (function(){
    var res = {};
    for (var i = 0; i < 10; i++) {
        res[~~(100*i/10)] = i;
    }
Severity: Major
Found in gauge.dev.js and 1 other location - About 2 hrs to fix
index.js on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function update has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

proto.update = function(){
    var w = this.el.clientWidth, h = this.el.clientHeight;
    var cw = this.colorsEl.clientWidth || w, ch = this.colorsEl.clientHeight || h;

    //1. Update colors
Severity: Minor
Found in gauge.dev.js - About 1 hr to fix

    Function update has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    proto.update = function(){
        var w = this.el.clientWidth, h = this.el.clientHeight;
        var cw = this.colorsEl.clientWidth || w, ch = this.colorsEl.clientHeight || h;
    
        //1. Update colors
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Function Gauge has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Gauge(el, options) {
          //ensure proper el is passed
          if (!(el instanceof HTMLElement)) throw Error('Bad target element');
      
          //ensure instance
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Function Gauge has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Gauge(el, options) {
            //ensure proper el is passed
            if (!(el instanceof HTMLElement)) throw Error('Bad target element');
        
            //ensure instance
        Severity: Minor
        Found in gauge.dev.js - About 1 hr to fix

          Function 3 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          },{}],3:[function(require,module,exports){
          var fakeStyle = require('./fake-element').style;
          var prefix = require('./prefix').dom;
          
          /**
          Severity: Minor
          Found in gauge.dev.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function getPercentAngle(percent, range){
                return ((percent * .01) * (range[1] - range[0]) + range[0]);
            }
            Severity: Minor
            Found in gauge.dev.js and 1 other location - About 30 mins to fix
            index.js on lines 282..284

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function getPercentAngle(percent, range){
                return ((percent * .01) * (range[1] - range[0]) + range[0]);
            }
            Severity: Minor
            Found in index.js and 1 other location - About 30 mins to fix
            gauge.dev.js on lines 283..285

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language