Sign upLogin

digipolisgent/robo-digipolis-deploy

View on GitHub
Star

Showing 34 of 34 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function digipolisDatabaseRestore($database = 'default', $opts = [
      'file-system-config|fsconf' => null,
      'database-config|dbconf' => null,
      'compression|c' => 'gzip',
      'source|s' => null,
Severity: Major
Found in src/Robo/Plugin/Commands/DigipolisDeployCommands.php and 1 other location - About 6 hrs to fix
src/Robo/Plugin/Commands/DigipolisDeployCommands.php on lines 39..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function digipolisDatabaseBackup(
        $database = 'default',
        $opts = [
            'file-system-config|fsconf' => null,
            'database-config|dbconf' => null,
Severity: Major
Found in src/Robo/Plugin/Commands/DigipolisDeployCommands.php and 1 other location - About 6 hrs to fix
src/Robo/Plugin/Commands/DigipolisDeployCommands.php on lines 71..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 206.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

SshPhpseclibAdapter has 44 functions (exceeds 20 allowed). Consider refactoring.
Open

class SshPhpseclibAdapter implements SshAdapterInterface
{

    /**
     * The phpseclib ssh client.
Severity: Minor
Found in src/Ssh/Adapter/SshPhpseclibAdapter.php - About 6 hrs to fix

    Method run has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run()
    {

        $ssh = call_user_func(
            [$this->sshFactory, 'create'],
    Severity: Major
    Found in src/PushPackage.php - About 3 hrs to fix

      Method run has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run()
    {
        try {
            $ssh = call_user_func(
                [$this->sshFactory, 'create'],
      Severity: Major
      Found in src/Ssh.php - About 2 hrs to fix

        Method getDumpCommandLine has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getDumpCommandLine($outputPath)
    {
        $this->config += [
            'ignoreTables' => [],
            'structureTables' => [],
        Severity: Minor
        Found in src/BackupManager/Databases/MysqlDatabase.php - About 1 hr to fix

          Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function run()
    {
        try {
            $ssh = call_user_func(
                [$this->sshFactory, 'create'],
          Severity: Minor
          Found in src/Ssh.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function run()
    {
        $sftp = call_user_func([$this->SFTPFactory, 'create'], $this->host, $this->auth, $this->port, $this->timeout);
        $errorMessage = '';
        foreach ($this->commandStack as $command) {
          Severity: Minor
          Found in src/SFTP.php - About 1 hr to fix

            Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function run()
    {
        try {
            /**
             * The backup manager
            Severity: Minor
            Found in src/DatabaseRestore.php - About 1 hr to fix

              Each class must be in a namespace of at least one level (a top-level vendor name)
              Open

              class RoboFile extends \Robo\Tasks
              Severity: Minor
              Found in RoboFile.php by phpcodesniffer

              Function cleanDir has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function cleanDir($dir, $keep)
    {
        $finder = clone $this->finder;
        $finder->in($dir);
        $finder->depth(0);
              Severity: Minor
              Found in src/PartialCleanDirs.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function expandTableNames has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function expandTableNames()
    {
        if (empty($this->tableList)) {
            $dsn = 'mysql:host=' . $this->config['host']
                . ';port=' . $this->config['port']
              Severity: Minor
              Found in src/BackupManager/Databases/MysqlDatabase.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method digipolisPushPackage has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $user,
        $host,
        $package,
        $destination = null,
        $opts = [
              Severity: Minor
              Found in src/Robo/Plugin/Commands/DigipolisDeployCommands.php - About 35 mins to fix

                Function doSort has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function doSort(Finder $finder)
    {
        switch ($this->sort) {
            case static::SORT_NAME:
                $finder->sortByName();
                Severity: Minor
                Found in src/PartialCleanDirs.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Missing class import via use statement (line '26', column '23').
                Open

                            throw new \RuntimeException(sprintf(
                Severity: Minor
                Found in src/Ssh/Auth/None.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '34', column '23').
                Open

                            throw new \RuntimeException(sprintf(
                Severity: Minor
                Found in src/Ssh/Auth/KeyFile.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '61', column '32').
                Open

                                $adapter = new \CacheTool\Adapter\FastCGI($this->host);
                Severity: Minor
                Found in src/ClearOpCache.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '17', column '23').
                Open

                            throw new \InvalidArgumentException(sprintf(
                Severity: Minor
                Found in src/Ssh/Auth/None.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '197', column '23').
                Open

                            $db = new \PDO($dsn, $this->config['user'], $this->config['pass']);
                Severity: Minor
                Found in src/BackupManager/Databases/MysqlDatabase.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Missing class import via use statement (line '34', column '23').
                Open

                            throw new \RuntimeException(sprintf(
                Severity: Minor
                Found in src/Ssh/Auth/Password.php by phpmd

                MissingImport

                Since: 2.7.0

                Importing all external classes in a file through use statements makes them clearly visible.

                Example

                function make() {
    return new \stdClass();
}

                Source http://phpmd.org/rules/cleancode.html#MissingImport

                Severity
                Category
                Status
                Source
                Language