digipolisgent/robo-digipolis-deploy

View on GitHub

Showing 34 of 34 total issues

Missing class import via use statement (line '34', column '23').
Open

            throw new \RuntimeException(sprintf(
Severity: Minor
Found in src/Ssh/Auth/KeyFile.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '87', column '23').
Open

            throw new \InvalidArgumentException(sprintf(
Severity: Minor
Found in src/DatabaseBackup.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '20', column '23').
Open

            throw new \InvalidArgumentException(sprintf(
Severity: Minor
Found in src/Ssh/Auth/Password.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '34', column '23').
Open

            throw new \RuntimeException(sprintf(
Severity: Minor
Found in src/Ssh/Auth/Password.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '61', column '32').
Open

                $adapter = new \CacheTool\Adapter\FastCGI($this->host);
Severity: Minor
Found in src/ClearOpCache.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '93', column '23').
Open

            throw new \InvalidArgumentException(sprintf(
Severity: Minor
Found in src/DatabaseRestore.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '24', column '23').
Open

            throw new \InvalidArgumentException(sprintf(
Severity: Minor
Found in src/Ssh/Auth/KeyFile.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        $sftp = call_user_func([$this->SFTPFactory, 'create'], $this->host, $this->auth, $this->port, $this->timeout);
        $errorMessage = '';
        foreach ($this->commandStack as $command) {
Severity: Minor
Found in src/SFTP.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$io'.
Open

        ConsoleIO $io,

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method run() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    public function run()
    {
        try {
            $ssh = call_user_func(
                [$this->sshFactory, 'create'],
Severity: Minor
Found in src/Ssh.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Line exceeds 120 characters; contains 143 characters
Open

class DigipolisDeployCommands extends \Robo\Tasks implements DigipolisPropertiesAwareInterface, ConfigAwareInterface, CustomEventAwareInterface

Line exceeds 120 characters; contains 135 characters
Open

        $key = PublicKeyLoader::load(file_get_contents($this->privateKeyFile), is_null($this->passphrase) ? false : $this->passphrase);
Severity: Minor
Found in src/Ssh/Auth/KeyFile.php by phpcodesniffer

The method SFTPFactory is not named in camelCase.
Open

    public function SFTPFactory($class)
    {
        if (!is_subclass_of($class, SFTPFactoryInterface::class)) {
            throw new InvalidArgumentException(sprintf(
                'SFTP Factory %s does not implement %s.',
Severity: Minor
Found in src/SFTP.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method SFTPFactory is not named in camelCase.
Open

    public function SFTPFactory($class)
    {
        if (!is_subclass_of($class, SFTPFactoryInterface::class)) {
            throw new InvalidArgumentException(sprintf(
                'SFTP Factory %s does not implement %s.',
Severity: Minor
Found in src/PushPackage.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language