digipolisgent/robo-digipolis-drupal8

View on GitHub

Showing 118 of 118 total issues

Method defaultDbConfig has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function defaultDbConfig()
    {
        $settings = $this->getRemoteSettings(null, null, null, null);
        $webDir = $this->getConfig()->get('digipolis.root.web', false);
        if (!$webDir) {
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php - About 1 hr to fix

    Method handle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handle(GenericEvent $event)
        {
            /** @var RemoteConfig $remoteConfig */
            $remoteConfig = $event->getArgument('remoteConfig');
            $remoteSettings = $remoteConfig->getRemoteSettings();
    Severity: Minor
    Found in src/EventHandler/ClearCacheHandler.php - About 1 hr to fix

      Avoid excessively long variable names like $enableMaintenanceMode. Keep variable name length under 20.
      Open

              $enableMaintenanceMode = CommandBuilder::create('cd')

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
          protected $reallyLongIntName = -3; // VIOLATION - Field
          public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
              $otherReallyLongName = -5; // VIOLATION - Local
              for ($interestingIntIndex = 0; // VIOLATION - For
                   $interestingIntIndex < 10;
                   $interestingIntIndex++ ) {
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#longvariable

      Method handle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function handle(GenericEvent $event)
          {
              /** @var RemoteConfig $remoteConfig */
              $remoteConfig = $event->getArgument('remoteConfig');
              $remoteSettings = $remoteConfig->getRemoteSettings();
      Severity: Minor
      Found in src/EventHandler/BackupRemoteHandler.php - About 1 hr to fix

        Method getLanguageUuids has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getLanguageUuids($uri = false, $aliases = [])
            {
                $aliases ??= [0 => false];
                $webDir = $this->getConfig()->get('digipolis.root.web', false);
                if (!$webDir) {
        Severity: Minor
        Found in src/Traits/Drupal8UtilsTrait.php - About 1 hr to fix

          Method addDrushInstallTask has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function addDrushInstallTask(
                CollectionBuilder $collection,
                array $options,
                array $aliases,
                string $profile,
          Severity: Minor
          Found in src/EventHandler/InstallDrupal8Handler.php - About 1 hr to fix

            Method handle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function handle(GenericEvent $event)
                {
                    /** @var RemoteConfig $remoteConfig */
                    $remoteConfig = $event->getArgument('remoteConfig');
                    $remoteSettings = $remoteConfig->getRemoteSettings();
            Severity: Minor
            Found in src/EventHandler/InstallHandler.php - About 1 hr to fix

              Method addConfigImportTask has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function addConfigImportTask(CollectionBuilder $collection, array $options, ?string $uri = null, array $aliases = [])
                  {
                      if ($options['config-import']) {
                          $drushBase = CommandBuilder::create('vendor/bin/drush');
                          if ($uri) {
              Severity: Minor
              Found in src/EventHandler/Drupal8Handler.php - About 1 hr to fix

                Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function handle(GenericEvent $event)
                    {
                        /** @var RemoteConfig $remoteConfig */
                        $remoteConfig = $event->getArgument('remoteConfig');
                        $remoteSettings = $remoteConfig->getRemoteSettings();
                Severity: Minor
                Found in src/EventHandler/BackupRemoteHandler.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function handle(GenericEvent $event)
                    {
                        /** @var RemoteConfig $remoteConfig */
                        $remoteConfig = $event->getArgument('remoteConfig');
                        $remoteSettings = $remoteConfig->getRemoteSettings();
                Severity: Minor
                Found in src/EventHandler/InstallHandler.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method handle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function handle(GenericEvent $event)
                    {
                        /** @var RemoteConfig $remoteConfig */
                        $remoteConfig = $event->getArgument('remoteConfig');
                        $remoteSettings = $remoteConfig->getRemoteSettings();
                Severity: Minor
                Found in src/EventHandler/RestoreBackupRemoteHandler.php - About 1 hr to fix

                  Avoid using undefined variables such as '$databases' which will lead to PHP notices.
                  Open

                              if (!isset($databases['default']['default'])) {

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$databases' which will lead to PHP notices.
                  Open

                              $config = $databases['default']['default'];

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$dbConfig' which will lead to PHP notices.
                  Open

                          return $dbConfig ?: false;

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$sites' which will lead to PHP notices.
                  Open

                          $aliases = isset($sites) && is_array($sites) ? ($aliases + $sites) : $aliases;
                  Severity: Minor
                  Found in src/Traits/AliasesHelper.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$dbConfig' which will lead to PHP notices.
                  Open

                              $dbConfig[$alias ?: 'default'] = [

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$sites' which will lead to PHP notices.
                  Open

                          $aliases = isset($sites) && is_array($sites) ? ($aliases + $sites) : $aliases;
                  Severity: Minor
                  Found in src/Traits/AliasesHelper.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$sites' which will lead to PHP notices.
                  Open

                          $aliases = isset($sites) && is_array($sites) ? ($aliases + $sites) : $aliases;
                  Severity: Minor
                  Found in src/Traits/AliasesHelper.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Avoid using undefined variables such as '$databases' which will lead to PHP notices.
                  Open

                          return $databases['default']['default'];
                  Severity: Minor
                  Found in src/EventHandler/Drupal8Handler.php by phpmd

                  UndefinedVariable

                  Since: 2.8.0

                  Detects when a variable is used that has not been defined before.

                  Example

                  class Foo
                  {
                      private function bar()
                      {
                          // $message is undefined
                          echo $message;
                      }
                  }

                  Source https://phpmd.org/rules/cleancode.html#undefinedvariable

                  Method handle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function handle(GenericEvent $event)
                      {
                          /** @var RemoteConfig $remoteConfig */
                          $remoteConfig = $event->getArgument('remoteConfig');
                          $remoteSettings = $remoteConfig->getRemoteSettings();
                  Severity: Minor
                  Found in src/EventHandler/PreRestoreBackupRemoteHandler.php - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language