Sign upLogin

digipolisgent/robo-digipolis-drupal8

View on GitHub
Star

Showing 118 of 118 total issues

Function addDrushInstallTask has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function addDrushInstallTask(
      CollectionBuilder $collection,
      array $options,
      array $aliases,
      string $profile,
Severity: Minor
Found in src/EventHandler/InstallDrupal8Handler.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Multi-line function declaration not indented correctly; expected 8 spaces but found 6
Open

      CollectionBuilder $collection,
Severity: Minor
Found in src/EventHandler/InstallDrupal8Handler.php by phpcodesniffer

Avoid unused local variables such as '$databases'.
Open

        return $databases['default']['default'];
Severity: Minor
Found in src/EventHandler/Drupal8Handler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$uri'.
Open

            foreach ($aliases as $uri => $alias) {
Severity: Minor
Found in src/EventHandler/RestoreBackupRemoteHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$app_root'.
Open

                $app_root = $webDir;
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$site_path'.
Open

            $site_path = 'sites' . $subdir;
Severity: Minor
Found in src/Traits/Drupal8UtilsTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method defaultDbConfig() has an NPath complexity of 528. The configured NPath complexity threshold is 200.
Open

    public function defaultDbConfig()
    {
        $settings = $this->getRemoteSettings(null, null, null, null);
        $webDir = $this->getConfig()->get('digipolis.root.web', false);
        if (!$webDir) {
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid unused local variables such as '$app_root'.
Open

            $app_root = $webDir;
Severity: Minor
Found in src/Traits/Drupal8UtilsTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$timeouts'.
Open

        $timeouts = $event->getArgument('timeouts');
Severity: Minor
Found in src/EventHandler/PreRestoreBackupRemoteHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$filesBackupFile'.
Open

        $filesBackupFile =  $this->backupFileName('.tar.gz', $remoteSettings['time']);
Severity: Minor
Found in src/EventHandler/RestoreBackupFilesLocalHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$uri'.
Open

        foreach ($aliases as $uri => $alias) {
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$uri'.
Open

            foreach ($aliases as $uri => $alias) {
Severity: Minor
Found in src/EventHandler/BackupRemoteHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method getDatabaseConfig uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        else {
            return new CommandError('No settings file found.');
        }
Severity: Minor
Found in src/EventHandler/Drupal8Handler.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid unused local variables such as '$app_root'.
Open

            $app_root = $webDir;
Severity: Minor
Found in src/Traits/Drupal8UtilsTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$currentWebRoot'.
Open

        $currentProjectRoot = $currentWebRoot = $remoteSettings['currentdir'] . '/..';
Severity: Minor
Found in src/EventHandler/ClearCacheHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$site_path'.
Open

            $site_path = 'sites' . $subdir;
Severity: Minor
Found in src/Traits/Drupal8UtilsTrait.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$site_path'.
Open

                $site_path = $subdir;
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid unused local variables such as '$fileBackupConfig'.
Open

        $fileBackupConfig = $event->getArgument('fileBackupConfig');
Severity: Minor
Found in src/EventHandler/PreRestoreBackupRemoteHandler.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The method defaultDbConfig() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    public function defaultDbConfig()
    {
        $settings = $this->getRemoteSettings(null, null, null, null);
        $webDir = $this->getConfig()->get('digipolis.root.web', false);
        if (!$webDir) {
Severity: Minor
Found in src/Robo/Plugin/Commands/DigipolisDrupal8DefaultHooksCommands.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method handle() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    public function handle(GenericEvent $event)
    {
        $event->stopPropagation();
        /** @var RemoteConfig $remoteConfig */
        $remoteConfig = $event->getArgument('remoteConfig');
Severity: Minor
Found in src/EventHandler/IsSiteInstalledHandler.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Severity
Category
Status
Source
Language