Sign upLogin

digipolisgent/robo-digipolis-drupal8

View on GitHub
Star
src/EventHandler/Drupal8Handler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method addConfigImportTask has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addConfigImportTask(CollectionBuilder $collection, array $options, ?string $uri = null, array $aliases = [])
    {
        if ($options['config-import']) {
            $drushBase = CommandBuilder::create('vendor/bin/drush');
            if ($uri) {
Severity: Minor
Found in src/EventHandler/Drupal8Handler.php - About 1 hr to fix

    Function addConfigImportTask has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addConfigImportTask(CollectionBuilder $collection, array $options, ?string $uri = null, array $aliases = [])
    {
        if ($options['config-import']) {
            $drushBase = CommandBuilder::create('vendor/bin/drush');
            if ($uri) {
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$databases' which will lead to PHP notices.
    Open

            return $databases['default']['default'];
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    The method getDatabaseConfig uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            else {
            return new CommandError('No settings file found.');
        }
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused local variables such as '$databases'.
    Open

            return $databases['default']['default'];
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Line exceeds 120 characters; contains 131 characters
    Open

        protected function addConfigImportTask(CollectionBuilder $collection, array $options, ?string $uri = null, array $aliases = [])
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpcodesniffer

    Expected 1 space after closing brace; newline found
    Open

            }
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpcodesniffer

    Expected 1 space after closing brace; newline found
    Open

            }
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpcodesniffer

    The variable $app_root is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $app_root is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $site_path is not named in camelCase.
    Open

        protected function getDatabaseConfig(array $aliases, ?string $uri = null): array
    {
        $app_root = $this->getConfig()->get('digipolis.root.web', false);
        $subfolder = $uri ? $aliases[$uri] : 'default';
        $site_path = $app_root . '/sites/' . $subfolder;
    Severity: Minor
    Found in src/EventHandler/Drupal8Handler.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status