digipolisgent/robo-digipolis-drupal8

View on GitHub
src/EventHandler/PreRestoreBackupRemoteHandler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method handle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(GenericEvent $event)
    {
        /** @var RemoteConfig $remoteConfig */
        $remoteConfig = $event->getArgument('remoteConfig');
        $remoteSettings = $remoteConfig->getRemoteSettings();
Severity: Minor
Found in src/EventHandler/PreRestoreBackupRemoteHandler.php - About 1 hr to fix

    Function handle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle(GenericEvent $event)
        {
            /** @var RemoteConfig $remoteConfig */
            $remoteConfig = $event->getArgument('remoteConfig');
            $remoteSettings = $remoteConfig->getRemoteSettings();
    Severity: Minor
    Found in src/EventHandler/PreRestoreBackupRemoteHandler.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid unused local variables such as '$timeouts'.
    Open

            $timeouts = $event->getArgument('timeouts');

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$fileBackupConfig'.
    Open

            $fileBackupConfig = $event->getArgument('fileBackupConfig');

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Blank line found at end of control structure
    Open

    
    

    Line exceeds 120 characters; contains 126 characters
    Open

    use DigipolisGent\Robo\Helpers\EventHandler\DefaultHandler\PreRestoreBackupRemoteHandler as PreRestoreBackupRemoteHandlerBase;

    Expected 1 space after FOREACH keyword; 0 found
    Open

                foreach($aliases as $uri => $alias) {

    There are no issues that match your filters.

    Category
    Status