Sign upLogin

digitalfabrik/integreat-app

View on GitHub
Star

Showing 189 of 190 total issues

File DatabaseConnector.ts has 766 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { BBox } from 'geojson'
import { map, mapValues } from 'lodash'
import { DateTime } from 'luxon'
import BlobUtil from 'react-native-blob-util'
import { rrulestr } from 'rrule'
Severity: Major
Found in native/src/utils/DatabaseConnector.ts - About 1 day to fix

    Function createConfig has 211 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createConfig = (
  env: {
    config_name?: string
    dev_server?: boolean
    bundle_analyzer?: boolean
    Severity: Major
    Found in web/tools/webpack.config.ts - About 1 day to fix

      Function Header has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
      Open

      const Header = ({
  navigation,
  route,
  availableLanguages,
  shareUrl,
      Severity: Minor
      Found in native/src/components/Header.tsx - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File renderHtml.ts has 365 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { TFunction } from 'i18next'
import { DefaultTheme } from 'styled-components/native'

import { ExternalSourcePermissions } from 'shared'
      Severity: Minor
      Found in native/src/utils/renderHtml.ts - About 4 hrs to fix

        DatabaseConnector has 36 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class DatabaseConnector {
  constructor() {
    this.migrationRoutine().catch(reportError)
  }
        Severity: Minor
        Found in native/src/utils/DatabaseConnector.ts - About 4 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const usePreviousProp = <T>({ prop, onPropChange }: UsePreviousPropProps<T>): T => {
  const [previousProp, setPreviousProp] = useState<T>(prop)

  useEffect(() => {
    if (previousProp !== prop) {
          Severity: Major
          Found in native/src/hooks/usePreviousProp.ts and 1 other location - About 4 hrs to fix
          web/src/hooks/usePreviousProp.ts on lines 8..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const usePreviousProp = <T>({ prop, onPropChange }: UsePreviousPropProps<T>): T => {
  const [previousProp, setPreviousProp] = useState<T>(prop)

  useEffect(() => {
    if (previousProp !== prop) {
          Severity: Major
          Found in web/src/hooks/usePreviousProp.ts and 1 other location - About 4 hrs to fix
          native/src/hooks/usePreviousProp.ts on lines 8..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function Navigator has 95 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const Navigator = (): ReactElement | null => {
  const showSnackbar = useSnackbar()
  const { settings, cityCode, changeCityCode, languageCode, updateSettings } = useAppContext()
  const navigation = useNavigation<NavigationProps<RoutesType>>()
  const [initialRoute, setInitialRoute] = useState<InitialRouteType>(null)
          Severity: Major
          Found in native/src/Navigator.tsx - About 3 hrs to fix

            Function Pois has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
            Open

            const Pois = ({ pois: allPois, language, cityModel, route, navigation, refresh }: PoisProps): ReactElement => {
  const { slug, multipoi, poiCategoryId, zoom } = route.params
  const [poiCurrentlyOpenFilter, setPoiCurrentlyOpenFilter] = useState(false)
  const [showFilterSelection, setShowFilterSelection] = useState(false)
  const [userLocation, setUserLocation] = useState<LocationType | null>(null)
            Severity: Minor
            Found in native/src/routes/Pois.tsx - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function ExportEventButton has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

            const ExportEventButton = ({ event }: ExportEventButtonType): ReactElement => {
  const { t } = useTranslation('events')
  const showSnackbar = useSnackbar()

  const [showCalendarChoiceModal, setShowCalendarChoiceModal] = useState<boolean>(false)
            Severity: Minor
            Found in native/src/components/ExportEventButton.tsx - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File webpack.config.ts has 311 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import ReactRefreshPlugin from '@pmmmwh/react-refresh-webpack-plugin'
import AssetsPlugin from 'assets-webpack-plugin'
import { CleanWebpackPlugin } from 'clean-webpack-plugin'
import CopyPlugin from 'copy-webpack-plugin'
import { readFileSync } from 'fs'
            Severity: Minor
            Found in web/tools/webpack.config.ts - About 3 hrs to fix

              Function CategoriesPage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
              Open

              const CategoriesPage = ({ city, pathname, cityCode, languageCode }: CityRouteProps): ReactElement | null => {
  const previousPathname = usePreviousProp({ prop: pathname })
  const categoryId = useParams()['*']
  const { t } = useTranslation('layout')
              Severity: Minor
              Found in web/src/routes/CategoriesPage.tsx - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function RemoteContent has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

              const RemoteContent = ({
  onLoad,
  content,
  cacheDictionary,
  resourceCacheUrl,
              Severity: Minor
              Found in native/src/components/RemoteContent.tsx - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File manage-metadata.ts has 299 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import { program } from 'commander'
import yaml from 'js-yaml'
import fs from 'node:fs'
import path from 'node:path'
              Severity: Minor
              Found in tools/manage-metadata.ts - About 3 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  if (developerFriendly()) {
    switch (level) {
      case 'fatal':
      case 'error':
        console.error(message)
                Severity: Major
                Found in native/src/utils/sentry.ts and 1 other location - About 3 hrs to fix
                web/src/utils/sentry.ts on lines 42..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (developerFriendly()) {
      switch (level) {
        case 'fatal':
        case 'error':
          console.error(message)
                Severity: Major
                Found in web/src/utils/sentry.ts and 1 other location - About 3 hrs to fix
                native/src/utils/sentry.ts on lines 29..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function navigate has 76 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const navigate = <T extends RoutesType>(
  routeInformation: RouteInformationType,
  navigation: NavigationProps<T>,
  appCityCode: string | null,
  appLanguageCode: string,
                Severity: Major
                Found in native/src/hooks/useNavigate.ts - About 3 hrs to fix

                  DefaultDataContainer has 26 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class DefaultDataContainer implements DataContainer {
  _databaseConnector: DatabaseConnector
  caches: CacheType

  constructor() {
                  Severity: Minor
                  Found in native/src/utils/DefaultDataContainer.ts - About 3 hrs to fix

                    Function render has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      render(): ReactElement | null {
    const { uri } = this.props
    const { imageDimensions, viewDimensions, interactive } = this.state

    if (!imageDimensions || !viewDimensions) {
                    Severity: Major
                    Found in native/src/components/PinchPanImage.tsx - About 3 hrs to fix

                      Function InfiniteScrollList has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                      Open

                      const InfiniteScrollList = <T,>({
  loadPage,
  noItemsMessage,
  renderItem,
  defaultPage,
                      Severity: Minor
                      Found in web/src/components/InfiniteScrollList.tsx - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language