Showing 189 of 190 total issues
Function request
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
async request(params: P, overrideUrl?: string): Promise<Payload<T>> {
if (this.errorOverride) {
throw this.errorOverride
}
Method fetchAsync
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
private fun fetchAsync(sourceUrl: String, targetFilePath: String, callback: FetchedCallback) {
val targetFile = File(targetFilePath)
if (targetFile.exists()) {
callback.alreadyExists(sourceUrl, targetFile)
return
Function request
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
const request = async (signal: SignalType) => {
const pageType = signal.name === OPEN_PAGE_SIGNAL_NAME ? signal.pageType : undefined
const signalUrl =
signal.name !== SEND_FEEDBACK_SIGNAL_NAME &&
signal.name !== RESUME_SIGNAL_NAME &&
Function CityContentHeader
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
const CityContentHeader = ({
cityModel,
languageCode,
languageChangePaths,
route,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function LoadingErrorHandler
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
const LoadingErrorHandler = ({
children,
loading,
refresh,
error,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function loadPois
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
async loadPois(context: DatabaseContext): Promise<Array<PoiModel>> {
const path = this.getContentPath('pois', context)
const mapPoisJson = (json: ContentPoiJsonType[]) =>
json.map(jsonObject => {
const jsonLocation = jsonObject.location
Function getNavigationItems
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
const getNavigationItems = (): Array<ReactElement> => {
const isNewsVisible = buildConfig().featureFlags.newsStream && (localNewsEnabled || tunewsEnabled)
const isEventsVisible = eventsEnabled
const isPoisVisible = buildConfig().featureFlags.pois && poisEnabled
Function CityContentToolbar
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
const CityContentToolbar = (props: CityContentToolbarProps) => {
const { viewportSmall } = useWindowDimensions()
const {
feedbackTarget,
children,
Function writeJsonFromCsv
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
const writeJsonFromCsv = (translations: string, toPath: string, sourceLanguage: string) => {
fs.readdir(translations, (err, files) => {
if (err) {
throw err
}
Function mapPoisJson
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
json.map(jsonObject => {
const jsonLocation = jsonObject.location
return new PoiModel({
path: jsonObject.path,
title: jsonObject.title,
Function storePois
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
async storePois(pois: Array<PoiModel>, context: DatabaseContext): Promise<void> {
const jsonModels = pois.map(
(poi: PoiModel): ContentPoiJsonType => ({
path: poi.path,
title: poi.title,
Function App
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
const App = (): ReactElement => {
const [routeIndex, setRouteIndex] = useState<number>(0)
useSendOfflineJpalSignals()
Function loadEvents
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
async loadEvents(context: DatabaseContext): Promise<Array<EventModel>> {
const path = this.getContentPath('events', context)
const mapEventsJson = (json: ContentEventJsonType[]) =>
json.map(jsonObject => {
const jsonDate = jsonObject.date
Function constructor
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor() {
this._databaseConnector = new DatabaseConnector()
this.caches = {
pois: new Cache<Array<PoiModel>>(
this._databaseConnector,
Function AppContextProvider
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
const AppContextProvider = ({ children }: AppContextProviderProps): ReactElement | null => {
const [settings, setSettings] = useState<SettingsType | null>(null)
const cityCode = settings?.selectedCity
const languageCode = settings?.contentLanguage
const { i18n } = useTranslation()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function EventsPage
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
const EventsPage = ({ city, pathname, languageCode, cityCode }: CityRouteProps): ReactElement | null => {
const previousPathname = usePreviousProp({ prop: pathname })
const { eventId } = useParams()
const { t } = useTranslation('events')
const navigate = useNavigate()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createConfig
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
const createConfig = (
env: {
config_name?: string
dev_server?: boolean
bundle_analyzer?: boolean
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
useEffect(() => {
import('../assets/licenses.json')
.then(licenseFile => setLicenses(parseLicenses(licenseFile.default)))
.catch(error => reportError(`error while importing licenses ${error}`))
}, [])
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 70.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
useEffect(() => {
import('../assets/licenses.json')
.then(licenseFile => setLicenses(parseLicenses(licenseFile.default)))
.catch(error => reportError(`error while importing licenses ${error}`))
}, [])
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 70.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function fetchAsync
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
func fetchAsync(sourceUrl: String, targetFilePath: String, collector: FetchResultCollector) {
let targetFileURL = URL(fileURLWithPath: targetFilePath)
let fileManager = FileManager.default