digitalfabrik/integreat-app

View on GitHub
web/src/routes/CategoriesPage.tsx

Summary

Maintainability
B
4 hrs
Test Coverage
F
35%

Function CategoriesPage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

const CategoriesPage = ({ city, pathname, cityCode, languageCode }: CityRouteProps): ReactElement | null => {
  const previousPathname = usePreviousProp({ prop: pathname })
  const categoryId = useParams()['*']
  const { t } = useTranslation('layout')

Severity: Minor
Found in web/src/routes/CategoriesPage.tsx - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

  if (!category || !parents || !categories) {
    // This adds support for the old paths of categories by redirecting to the new path
    // The children endpoint always returns the category with the new path at the first position in the response
    const newSlugCategory = categories?.[0]
    if (newSlugCategory) {
Severity: Major
Found in web/src/routes/CategoriesPage.tsx - About 40 mins to fix

    Avoid too many return statements within this function.
    Open

      return (
        <CityContentLayout isLoading={false} {...locationLayoutParams}>
          <Helmet
            pageTitle={pageTitle}
            metaDescription={metaDescription}
    Severity: Major
    Found in web/src/routes/CategoriesPage.tsx - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status