Sign upLogin

digitalfabrik/integreat-app

View on GitHub
Star
web/src/routes/LocalNewsPage.tsx

Summary

Maintainability
A
2 hrs
Test Coverage
F
41%

Function LocalNewsPage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

const LocalNewsPage = ({ city, pathname, languageCode, cityCode }: CityRouteProps): ReactElement | null => {
  const previousPathname = usePreviousProp({ prop: pathname })
  const { newsId } = useParams()
  const { t } = useTranslation('news')
  const navigate = useNavigate()
Severity: Minor
Found in web/src/routes/LocalNewsPage.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return (
    <CityContentLayout isLoading={false} {...locationLayoutParams}>
      <Helmet pageTitle={pageTitle} languageChangePaths={languageChangePaths} cityModel={city} />
      <NewsTabs
        type={LOCAL_NEWS_TYPE}
Severity: Major
Found in web/src/routes/LocalNewsPage.tsx - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status