Sign upLogin

dlundgren/watchtower

View on GitHub
Star

Showing 7 of 7 total issues

Function checkGroups has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function checkGroups($ldap, Event $event)
    {
        $searchResult = ldap_search(
            $ldap,
            $this->baseDn,
Severity: Minor
Found in src/Sentry/Authentication/Ldap.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method discern has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function discern(Event $event)
    {
        if (!($event instanceof Authenticate)) {
            return;
        }
Severity: Minor
Found in src/Sentry/Authentication/Ldap.php - About 1 hr to fix

    Function discern has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function discern(Event $event)
    {
        if (!($event instanceof Authenticate)) {
            return;
        }
    Severity: Minor
    Found in src/Sentry/Authentication/Ldap.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function triggerAndReturnIdentity has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        private function triggerAndReturnIdentity(Event $event)
    {
        if (empty($this->sentries)) {
            $event->triggerError(Sentry::INVALID, "No sentries available");
        }
    Severity: Minor
    Found in src/WatchTower.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($name, $dsn, $identityField, $groups = null, $breakChainOnFailure = false)
    Severity: Minor
    Found in src/Sentry/Authentication/Ldap.php - About 35 mins to fix

      Function discern has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function discern(Event $event)
    {
        if ($event instanceof Identify && isset($this->ip)) {
            $ip       = ip2long($this->ip);
            $identity = $event->identity();
      Severity: Minor
      Found in src/Sentry/Identification/Stealth/IpBasic.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return;
      Severity: Major
      Found in src/Sentry/Authentication/Ldap.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language