Sign upLogin

docker/swarmkit

View on GitHub
Star
agent/exec/controller.go

Summary

Maintainability
D
1 day
Test Coverage

Function Do has a Cognitive Complexity of 67 (exceeds 20 allowed). Consider refactoring.
Open

func Do(ctx context.Context, task *api.Task, ctlr Controller) (*api.TaskStatus, error) {
    status := task.Status.Copy()

    // stay in the current state.
    noop := func(errs ...error) (*api.TaskStatus, error) {
Severity: Minor
Found in agent/exec/controller.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Do has 141 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Do(ctx context.Context, task *api.Task, ctlr Controller) (*api.TaskStatus, error) {
    status := task.Status.Copy()

    // stay in the current state.
    noop := func(errs ...error) (*api.TaskStatus, error) {
Severity: Major
Found in agent/exec/controller.go - About 4 hrs to fix

    Function Do has 20 return statements (exceeds 4 allowed).
    Open

    func Do(ctx context.Context, task *api.Task, ctlr Controller) (*api.TaskStatus, error) {
    status := task.Status.Copy()

    // stay in the current state.
    noop := func(errs ...error) (*api.TaskStatus, error) {
    Severity: Major
    Found in agent/exec/controller.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status