Sign upLogin

docker/swarmkit

View on GitHub
Star
ca/renewer.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method TLSRenewer.Start has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (t *TLSRenewer) Start(ctx context.Context) <-chan CertificateUpdate {
    updates := make(chan CertificateUpdate)

    go func() {
        var (
Severity: Minor
Found in ca/renewer.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method TLSRenewer.Start has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (t *TLSRenewer) Start(ctx context.Context) <-chan CertificateUpdate {
    updates := make(chan CertificateUpdate)

    go func() {
        var (
Severity: Major
Found in ca/renewer.go - About 2 hrs to fix

    Method TLSRenewer.Start has 5 return statements (exceeds 4 allowed).
    Open

    func (t *TLSRenewer) Start(ctx context.Context) <-chan CertificateUpdate {
    updates := make(chan CertificateUpdate)

    go func() {
        var (
    Severity: Major
    Found in ca/renewer.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status