Sign upLogin

docker/swarmkit

View on GitHub
Star
ca/server.go

Summary

Maintainability
D
3 days
Test Coverage

File server.go has 672 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package ca

import (
    "bytes"
    "context"
Severity: Minor
Found in ca/server.go - About 6 hrs to fix

    Method Server.Run has 102 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *Server) Run(ctx context.Context) error {
    s.mu.Lock()
    if s.isRunning() {
        s.mu.Unlock()
        return errors.New("CA signer is already running")
    Severity: Major
    Found in ca/server.go - About 3 hrs to fix

      Method Server.IssueNodeCertificate has 91 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *Server) IssueNodeCertificate(ctx context.Context, request *api.IssueNodeCertificateRequest) (*api.IssueNodeCertificateResponse, error) {
    // First, let's see if the remote node is presenting a non-empty CSR
    if len(request.CSR) == 0 {
        return nil, status.Errorf(codes.InvalidArgument, codes.InvalidArgument.String())
    }
      Severity: Major
      Found in ca/server.go - About 2 hrs to fix

        Method Server.signNodeCert has 91 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (s *Server) signNodeCert(ctx context.Context, node *api.Node) error {
    s.signingMu.Lock()
    rootCA := s.localRootCA
    externalCA := s.externalCA
    s.signingMu.Unlock()
        Severity: Major
        Found in ca/server.go - About 2 hrs to fix

          Method Server.UpdateRootCA has 65 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (s *Server) UpdateRootCA(ctx context.Context, cluster *api.Cluster, reconciler *rootRotationReconciler) error {
    s.mu.Lock()
    s.joinTokens = cluster.RootCA.JoinTokens.Copy()
    s.mu.Unlock()
    rCA := cluster.RootCA.Copy()
          Severity: Minor
          Found in ca/server.go - About 1 hr to fix

            Method Server.Run has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
            Open

            func (s *Server) Run(ctx context.Context) error {
    s.mu.Lock()
    if s.isRunning() {
        s.mu.Unlock()
        return errors.New("CA signer is already running")
            Severity: Minor
            Found in ca/server.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method Server.NodeCertificateStatus has 62 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (s *Server) NodeCertificateStatus(ctx context.Context, request *api.NodeCertificateStatusRequest) (*api.NodeCertificateStatusResponse, error) {
    if request.NodeID == "" {
        return nil, status.Errorf(codes.InvalidArgument, codes.InvalidArgument.String())
    }
            Severity: Minor
            Found in ca/server.go - About 1 hr to fix

              Method Server.IssueNodeCertificate has 10 return statements (exceeds 4 allowed).
              Open

              func (s *Server) IssueNodeCertificate(ctx context.Context, request *api.IssueNodeCertificateRequest) (*api.IssueNodeCertificateResponse, error) {
    // First, let's see if the remote node is presenting a non-empty CSR
    if len(request.CSR) == 0 {
        return nil, status.Errorf(codes.InvalidArgument, codes.InvalidArgument.String())
    }
              Severity: Major
              Found in ca/server.go - About 1 hr to fix

                Method Server.signNodeCert has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
                Open

                func (s *Server) signNodeCert(ctx context.Context, node *api.Node) error {
    s.signingMu.Lock()
    rootCA := s.localRootCA
    externalCA := s.externalCA
    s.signingMu.Unlock()
                Severity: Minor
                Found in ca/server.go - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method Server.signNodeCert has 9 return statements (exceeds 4 allowed).
                Open

                func (s *Server) signNodeCert(ctx context.Context, node *api.Node) error {
    s.signingMu.Lock()
    rootCA := s.localRootCA
    externalCA := s.externalCA
    s.signingMu.Unlock()
                Severity: Major
                Found in ca/server.go - About 55 mins to fix

                  Method Server.NodeCertificateStatus has 9 return statements (exceeds 4 allowed).
                  Open

                  func (s *Server) NodeCertificateStatus(ctx context.Context, request *api.NodeCertificateStatusRequest) (*api.NodeCertificateStatusResponse, error) {
    if request.NodeID == "" {
        return nil, status.Errorf(codes.InvalidArgument, codes.InvalidArgument.String())
    }
                  Severity: Major
                  Found in ca/server.go - About 55 mins to fix

                    Method Server.Run has 6 return statements (exceeds 4 allowed).
                    Open

                    func (s *Server) Run(ctx context.Context) error {
    s.mu.Lock()
    if s.isRunning() {
        s.mu.Unlock()
        return errors.New("CA signer is already running")
                    Severity: Major
                    Found in ca/server.go - About 40 mins to fix

                      Method Server.UpdateRootCA has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                      Open

                      func (s *Server) UpdateRootCA(ctx context.Context, cluster *api.Cluster, reconciler *rootRotationReconciler) error {
    s.mu.Lock()
    s.joinTokens = cluster.RootCA.JoinTokens.Copy()
    s.mu.Unlock()
    rCA := cluster.RootCA.Copy()
                      Severity: Minor
                      Found in ca/server.go - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      func (s *Server) isRunningLocked() (context.Context, error) {
    s.mu.Lock()
    if !s.isRunning() {
        s.mu.Unlock()
        return nil, status.Errorf(codes.Aborted, "CA signer is stopped")
                      Severity: Minor
                      Found in ca/server.go and 1 other location - About 45 mins to fix
                      manager/dispatcher/dispatcher.go on lines 410..419

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 116.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status