Sign upLogin

docker/swarmkit

View on GitHub
Star

Showing 1,008 of 1,820 total issues

Method ClusterSnapshot.Unmarshal has 157 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (m *ClusterSnapshot) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
Severity: Major
Found in api/snapshot.pb.go - About 5 hrs to fix

    Method TaskReaper.Run has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring.
    Open

    func (tr *TaskReaper) Run(ctx context.Context) {
    watcher, watchCancel := state.Watch(tr.store.WatchQueue(), api.EventCreateTask{}, api.EventUpdateTask{}, api.EventUpdateCluster{})

    defer func() {
        close(tr.doneChan)
    Severity: Minor
    Found in manager/orchestrator/taskreaper/task_reaper.go - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Allocator.doNetworkAlloc has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring.
    Open

    func (a *Allocator) doNetworkAlloc(ctx context.Context, ev events.Event) {
    nc := a.netCtx

    switch v := ev.(type) {
    case api.EventCreateNetwork:
    Severity: Minor
    Found in manager/allocator/network.go - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method VolumeSpec.Unmarshal has 60 return statements (exceeds 4 allowed).
    Open

    func (m *VolumeSpec) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
    Severity: Major
    Found in api/specs.pb.go - About 5 hrs to fix

      Function parseResource has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
      Open

      func parseResource(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if flags.Changed("memory-reservation") {
        if spec.Task.Resources == nil {
            spec.Task.Resources = &api.ResourceRequirements{}
        }
      Severity: Minor
      Found in swarmd/cmd/swarmctl/service/flagparser/resource.go - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Reconciler.ReconcileService has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r *Reconciler) ReconcileService(id string) error {
    var (
        service *api.Service
        tasks   []*api.Task
        cluster *api.Cluster
      Severity: Minor
      Found in manager/orchestrator/jobs/replicated/reconciler.go - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Dispatcher.Tasks has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
      Open

      func (d *Dispatcher) Tasks(r *api.TasksRequest, stream api.Dispatcher_TasksServer) error {
    d.rpcRW.RLock()
    defer d.rpcRW.RUnlock()

    dctx, err := d.isRunningLocked()
      Severity: Minor
      Found in manager/dispatcher/dispatcher.go - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Meta.Unmarshal has 152 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (m *Meta) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
      Severity: Major
      Found in api/objects.pb.go - About 5 hrs to fix

        Method IssueNodeCertificateRequest.Unmarshal has 151 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (m *IssueNodeCertificateRequest) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
        Severity: Major
        Found in api/ca.pb.go - About 5 hrs to fix

          Method Endpoint.Unmarshal has 151 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (m *Endpoint) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
          Severity: Major
          Found in api/objects.pb.go - About 5 hrs to fix

            Method ConfigSpec.Unmarshal has 150 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (m *ConfigSpec) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
            Severity: Major
            Found in api/specs.pb.go - About 5 hrs to fix

              Method ContainerSpec.Size has 150 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (m *ContainerSpec) Size() (n int) {
    if m == nil {
        return 0
    }
    var l int
              Severity: Major
              Found in api/specs.pb.go - About 5 hrs to fix

                Method Updater.Run has 149 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (u *Updater) Run(ctx context.Context, slots []orchestrator.Slot) {
    defer close(u.doneChan)

    service := u.newService
                Severity: Major
                Found in manager/orchestrator/update/updater.go - About 4 hrs to fix

                  Method Dispatcher.Assignments has 148 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (d *Dispatcher) Assignments(r *api.AssignmentsRequest, stream api.Dispatcher_AssignmentsServer) error {
    d.rpcRW.RLock()
    defer d.rpcRW.RUnlock()

    dctx, err := d.isRunningLocked()
                  Severity: Major
                  Found in manager/dispatcher/dispatcher.go - About 4 hrs to fix

                    Method Orchestrator.reconcileServices has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func (g *Orchestrator) reconcileServices(ctx context.Context, serviceIDs []string) {
    nodeTasks := make(map[string]map[string][]*api.Task)

    g.store.View(func(tx store.ReadTx) {
        for _, serviceID := range serviceIDs {
                    Severity: Minor
                    Found in manager/orchestrator/global/global.go - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method Config.Unmarshal has 145 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func (m *Config) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
                    Severity: Major
                    Found in api/objects.pb.go - About 4 hrs to fix

                      Method StoreSnapshot.MarshalToSizedBuffer has 145 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (m *StoreSnapshot) MarshalToSizedBuffer(dAtA []byte) (int, error) {
    i := len(dAtA)
    _ = i
    var l int
    _ = l
                      Severity: Major
                      Found in api/snapshot.pb.go - About 4 hrs to fix

                        Method HealthCheckResponse.Unmarshal has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (m *HealthCheckResponse) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
                        Severity: Minor
                        Found in api/health.pb.go - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method ResolveAddressRequest.Unmarshal has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (m *ResolveAddressRequest) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
                        Severity: Minor
                        Found in api/raft.pb.go - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method ReplicatedService.Unmarshal has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (m *ReplicatedService) Unmarshal(dAtA []byte) error {
    l := len(dAtA)
    iNdEx := 0
    for iNdEx < l {
        preIndex := iNdEx
                        Severity: Minor
                        Found in api/specs.pb.go - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language