Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/csi/manager.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Manager.handleVolume has 72 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (vm *Manager) handleVolume(ctx context.Context, id string) error {
    var volume *api.Volume
    vm.store.View(func(tx store.ReadTx) {
        volume = store.GetVolume(tx, id)
    })
Severity: Minor
Found in manager/csi/manager.go - About 1 hr to fix

    Method Manager.handleVolume has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func (vm *Manager) handleVolume(ctx context.Context, id string) error {
    var volume *api.Volume
    vm.store.View(func(tx store.ReadTx) {
        volume = store.GetVolume(tx, id)
    })
    Severity: Minor
    Found in manager/csi/manager.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Manager.handleVolume has 8 return statements (exceeds 4 allowed).
    Open

    func (vm *Manager) handleVolume(ctx context.Context, id string) error {
    var volume *api.Volume
    vm.store.View(func(tx store.ReadTx) {
        volume = store.GetVolume(tx, id)
    })
    Severity: Major
    Found in manager/csi/manager.go - About 50 mins to fix

      Method Manager.getPlugin has 5 return statements (exceeds 4 allowed).
      Open

      func (vm *Manager) getPlugin(name string) (Plugin, error) {
    // if the plugin already exists, we can just return it.
    if p, ok := vm.plugins[name]; ok {
        return p, nil
    }
      Severity: Major
      Found in manager/csi/manager.go - About 35 mins to fix

        Method Manager.createVolume has 5 return statements (exceeds 4 allowed).
        Open

        func (vm *Manager) createVolume(ctx context.Context, v *api.Volume) error {
    l := log.G(ctx).WithField("volume.id", v.ID).WithField("driver", v.Spec.Driver.Name)
    l.Info("creating volume")

    p, err := vm.getPlugin(v.Spec.Driver.Name)
        Severity: Major
        Found in manager/csi/manager.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status